helm-fan-out script to prepare a release. #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each file need to be on its own file to be released (and taken into account but `catalog-cd release`. This adds a script to do that, in preparation of a "make release" target. Signed-off-by: Vincent Demeester <[email protected]>
otaviof
reviewed
Sep 28, 2023
Comment on lines
+1
to
+26
| #!/usr/bin/env bash | ||
| # Based on https://github.com/helm/helm/issues/4680#issuecomment-1152289297 | ||
| # helm-fan-out | ||
|
|
||
| if [ -z "$1" ]; then | ||
| echo "Please provide an output directory" | ||
| exit 1 | ||
| fi | ||
|
|
||
| awk -vout="$1" -F": " ' | ||
| $0~/^# Source: / { | ||
| file=out"/"$2; | ||
| if (!(file in filemap)) { | ||
| filemap[file] = 1 | ||
| print "Creating "file; | ||
| system ("mkdir -p $(dirname "file")"); | ||
| } | ||
| print "---" >> file; | ||
| } | ||
| $0!~/^# Source: / { | ||
| if ($0!~/^---$/) { | ||
| if (file) { | ||
| print $0 >> file; | ||
| } | ||
| } | ||
| }' |
There was a problem hiding this comment.
I think we can use helm template to render the individual files by adopting the --show-only flag. As in the following example:
for t in $(ls -1 templates/task-*.yaml); do
task_file="$(basename ${t})"
echo "# Rendering template ${t} into ${task_file}"
make helm-template ARGS="--show-only=${t}" >/tmp/${task_file}
doneA better place for this is the Makefile, adding a new helm-template-tasks target, i.e.:
helm-template-tasks:
for t in $(ls -1 templates/task-*.yaml); do
helm template --show-only=${t} >/tmp/`basename ${t}``
doneWith a configurable directory instead of /tmp like on the example above. So the task repository can prepare it's own files for later release.
WDYT?
There was a problem hiding this comment.
Interesting, I didn't know that, it would definitely be better then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each file need to be on its own file to be released (and taken into
account but
catalog-cd release. This adds a script to do that, inpreparation of a "make release" target.
Signed-off-by: Vincent Demeester [email protected]