Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-5397 | feat: add aws, account roles and oidc config common #26

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

gdbranco
Copy link
Collaborator

@gdbranco gdbranco commented Jan 5, 2024

Related issue: OCM-5397

@gdbranco gdbranco force-pushed the feat/ocm-5397 branch 3 times, most recently from a7a5de5 to 2c9ff91 Compare January 5, 2024 15:17
@gdbranco gdbranco changed the title OCM-5397 | add aws, account roles and oidc config common OCM-5397 | feat: add aws, account roles and oidc config common Jan 5, 2024
@gdbranco gdbranco force-pushed the feat/ocm-5397 branch 2 times, most recently from 12bd7e4 to dab32e7 Compare January 5, 2024 17:51
Copy link
Contributor

@nirarg nirarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looks good
Just a minor comment, not necessary needed to be fixed
/lgtm

pkg/consts.go Show resolved Hide resolved
@den-rgb
Copy link

den-rgb commented Jan 8, 2024

lgtm

@gdbranco gdbranco merged commit e4147c4 into openshift-online:main Jan 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants