OCM-5027 | feat: Added KubeletConfigClient and mock to be shared between ROSA and Terraform #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robpblake
force-pushed
the
ocm-5027-common-kubeletclient-alternative
branch
from
6aaf896 to
b61384a
Compare
ciaranRoche
reviewed
Dec 7, 2023
robpblake
force-pushed
the
ocm-5027-common-kubeletclient-alternative
branch
from
b61384a to
0fd7aec
Compare
ciaranRoche
approved these changes
Dec 7, 2023
…een Terraform and ROSA CLI
robpblake
force-pushed
the
ocm-5027-common-kubeletclient-alternative
branch
from
0fd7aec to
121e250
Compare
robpblake
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR arises as a result of a conversation between @nirarg and myself when discussing terraform-redhat/terraform-provider-rhcs#413
In terraform-redhat/terraform-provider-rhcs#413 I have created
KubeletConfigClientinterface that wraps the OCM SDK. The purpose of this approach is to make it easier to test implementations that have a dependency on the OCM SDK as we can replace the implementation with agomockbased one in the unit tests.By moving this into
ocm-common, we hope to start a process of using the same approach in both TF and ROSA CLI and gradually expanding the number of clients we support. Consider this PR a "POC" that implements a handful of clients and provides some initial versions of base structs and interfaces to help us build upon this work.With this PR merged, I will update terraform-redhat/terraform-provider-rhcs#413 to use this approach.