Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP webui: Allow embedding a webui service #1477

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

celebdor
Copy link
Collaborator

@celebdor celebdor commented Nov 8, 2022

dev-scripts currently supports running webui on node0 by sshing into it and using podman to run a webui image. This commits adds the ability to embed the logic to run the webui in the image itself, so it will run as soon as possible.

There should be some follow-up work to embed the image itself into the ISO to allow for disconnected. Until then, one could put the image reference to point to dev-scripts registry.

Signed-off-by: Antoni Segura Puimedon [email protected]

dev-scripts currently supports running webui on node0 by sshing into it
and using podman to run a webui image. This commits adds the ability to
embed the logic to run the webui in the image itself, so it will run as
soon as possible.

There should be some follow-up work to embed the image itself into the
ISO to allow for disconnected. Until then, one could put the image
reference to point to dev-scripts registry.

Signed-off-by: Antoni Segura Puimedon <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 8, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from celebdor by writing /assign @celebdor in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@celebdor celebdor changed the title WIP webui: Allow embedding a webui image WIP webui: Allow embedding a webui service Nov 8, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2022
@openshift-merge-robot
Copy link

@celebdor: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flaper87
Copy link
Contributor

/unassign @flaper87

@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

@celebdor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4 7cdb7f6 link true /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants