tests: add coverage report and increase coverage #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for us to go chase where we can improve the unit test coverage. Note the default top-level targets do NOT call the cover-variants and, at this point in time, there's no reason why they ever should. Signed-off-by: Francesco Romani <[email protected]>
add basic unit test coverage which was missing from the introducing PR Signed-off-by: Francesco Romani <[email protected]>
add basic unit test coverage which was missing from the introducing PR Signed-off-by: Francesco Romani <[email protected]>
add basic unit test coverage which was missing from the introducing PR Signed-off-by: Francesco Romani <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold more tests coming |
openshift-ci
bot
added
the
do-not-merge/hold
ffromani
force-pushed
the
test-coverage-20241121
branch
from
5f80768
to
f798d8f
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
infra issue (?!) |
|
Thanks for the valuable tests |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
shajmakh
reviewed
Nov 22, 2024
add basic unit test coverage which was missing from the introducing PR Signed-off-by: Francesco Romani <[email protected]>
add missing (basic) test Signed-off-by: Francesco Romani <[email protected]>
this code is obsolete since a good while. Signed-off-by: Francesco Romani <[email protected]>
add explicit and basic test coverage for FindConditions Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
test-coverage-20241121
branch
from
f798d8f
to
fa65142
Compare
|
New changes are detected. LGTM label has been removed. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
more precise coverage run: let's focus on packages we control, ignoring autogenerated functions (e.g. deepcopy) Signed-off-by: Francesco Romani <[email protected]>
add initial base coverage for the only function in the pkg which didn't had test coverage Signed-off-by: Francesco Romani <[email protected]>
we have a dependency (govalidator) which we import for exactly one function which is pretty simple to replace. We do it in this patch. Signed-off-by: Francesco Romani <[email protected]>
|
I think the problem is we lose events. This would explain the flakiness |
|
/retest-required |
|
|
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add developer (not yet CI, if ever) facilities to see the test coverage, and improve unit test coverage for recently added packages