-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for agentclusterinstall #434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @achuzhoy |
/cc @kononovn |
trewest
force-pushed
the
add-aci-unittests
branch
from
May 21, 2024 17:54
377f427
to
8f5d5c6
Compare
achuzhoy
reviewed
May 21, 2024
achuzhoy
reviewed
May 21, 2024
achuzhoy
reviewed
May 21, 2024
achuzhoy
previously approved these changes
May 21, 2024
/lgtm |
trewest
force-pushed
the
add-aci-unittests
branch
2 times, most recently
from
May 22, 2024 13:16
2a23de4
to
9928e08
Compare
kononovn
reviewed
May 22, 2024
kononovn
reviewed
May 22, 2024
kononovn
requested changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor comments
trewest
force-pushed
the
add-aci-unittests
branch
from
May 22, 2024 15:16
9928e08
to
fe75f58
Compare
kononovn
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests for the agentclusterinstall resource in the assisted pkg
Needed for #295