Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for agentclusterinstall #434

Merged
merged 1 commit into from
May 22, 2024

Conversation

trewest
Copy link
Collaborator

@trewest trewest commented May 21, 2024

Adds unit tests for the agentclusterinstall resource in the assisted pkg

Needed for #295

@trewest trewest requested a review from kononovn as a code owner May 21, 2024 16:42
@trewest
Copy link
Collaborator Author

trewest commented May 21, 2024

/cc @achuzhoy

@trewest trewest requested a review from achuzhoy May 21, 2024 16:48
@trewest
Copy link
Collaborator Author

trewest commented May 21, 2024

/cc @kononovn

achuzhoy
achuzhoy previously approved these changes May 21, 2024
@achuzhoy
Copy link
Collaborator

/lgtm

@trewest trewest force-pushed the add-aci-unittests branch 2 times, most recently from 2a23de4 to 9928e08 Compare May 22, 2024 13:16
Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor comments

Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kononovn kononovn merged commit 209e571 into openshift-kni:main May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants