Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start relying on ci base image for CI #5743

Merged

Conversation

joepvd
Copy link
Contributor

@joepvd joepvd commented Nov 26, 2024

follow-up of #5618

@openshift-bot
Copy link

Validating 1 file(s)...
Validating images/openshift-base-rhel9.yml...
✅ Validated images/openshift-base-rhel9.yml

@openshift-bot
Copy link

Validating 5 file(s)...
Validating images/ci-openshift-build-root-previous.rhel8.yml...
✅ Validated images/ci-openshift-build-root-previous.rhel8.yml
Validating images/ci-openshift-build-root-previous.rhel9.yml...
✅ Validated images/ci-openshift-build-root-previous.rhel9.yml
Validating images/ci-openshift-golang-builder-previous.rhel8.yml...
Traceback (most recent call last):
File "/usr/local/bin/validate-ocp-build-data", line 33, in
sys.exit(load_entry_point('rh-ocp-build-data-validator==0.2.5', 'console_scripts', 'validate-ocp-build-data')())
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 87, in main
validate(f, args.exclude_vpn, args.schema_only)
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 23, in validate
support.fail_validation(msg, parsed)
File "/usr/local/lib/python3.9/site-packages/validator/support.py", line 14, in fail_validation
raise exceptions.ValidationFailed(msg)
validator.exceptions.ValidationFailed: Schema mismatch: images/ci-openshift-golang-builder-previous.rhel8.yml
Returned error: Additional properties are not allowed ('upstream_image_mirror' was unexpected)

Copy link

@locriandev locriandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@joepvd
Copy link
Contributor Author

joepvd commented Nov 26, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 58af686 into openshift-eng:openshift-4.19 Nov 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants