Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "ART-11389 - Bump 4.18 golang builders to 1.22.9"" #5727

Merged

Conversation

joepvd
Copy link
Contributor

@joepvd joepvd commented Nov 22, 2024

Reverts #5711

@openshift-bot
Copy link

Validating 1 file(s)...
✅ Validated streams.yml

@joepvd
Copy link
Contributor Author

joepvd commented Nov 22, 2024

/hold
let's wait for:

  1. flowing nightlies
  2. no ack-critical-fixes-only label

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2024
@joepvd
Copy link
Contributor Author

joepvd commented Nov 25, 2024

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 25, 2024
@joepvd
Copy link
Contributor Author

joepvd commented Nov 25, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@ashwindasr ashwindasr merged commit 63b7b01 into openshift-4.18 Nov 25, 2024
1 of 2 checks passed
@ashwindasr ashwindasr deleted the revert-5711-revert-5700-update-golang-4.18-1.22.9 branch November 25, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants