Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to automate PR create for new images #150

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DennisPeriquet
Copy link

@DennisPeriquet DennisPeriquet commented Oct 22, 2024

https://issues.redhat.com/browse/ART-10508

This PR adds a /git_jira_api endpoint to the ART ui server backend so that we can call it from the ART UI frontend to create a PR and Jira automatically.

I chose to implement this in the backend because trying to create a PR via the git api from the front end would result in a CORS (Cross Origin Resource Sharing) problem. Our Django settings allow CORS so creating a PR via the backend is fine.

If this is merged, it will lay dormant until something like this PR calls it.

Other:

  • I created a Makefile to help setup a development environment (including debugging in vscode in the container using ssh), and run builds, but I'm still working on smoothing out the workflow.

Copy link
Contributor

openshift-ci bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mbiarnes for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DennisPeriquet
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2024
@DennisPeriquet DennisPeriquet force-pushed the fix_docker1 branch 6 times, most recently from 2446dd0 to 77a56a4 Compare October 27, 2024 12:19
@DennisPeriquet DennisPeriquet force-pushed the fix_docker1 branch 7 times, most recently from 60f33e7 to f120290 Compare November 2, 2024 13:07
@DennisPeriquet DennisPeriquet force-pushed the fix_docker1 branch 2 times, most recently from 7c4fa08 to 836b832 Compare November 4, 2024 15:48
@DennisPeriquet
Copy link
Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant