MGMT-19346: Enable 4/5 CPN to Cluster Details Form - 2.14 #2739
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ammont82: This pull request references MGMT-19346 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ammont82 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
size/L
|
screenshot please |
|
@ammont82: This pull request references MGMT-19346 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Don't we need a "?" with some explanation text? |
|
@ammont82: This pull request references MGMT-19346 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| {!isNutanix && ( | ||
| <> | ||
| <SNOControlGroup versions={versions} highAvailabilityMode={highAvailabilityMode} /> |
There was a problem hiding this comment.
I think we can remove the SNOControlGroup component now. And any others that this PR renders unused.
There was a problem hiding this comment.
We need the SNODisclaimer.
I think we can remove this component.
libs/ui-lib/lib/common/components/clusterWizard/clusterDetailsValidation.ts
Show resolved
Hide resolved
| {selectedValue ? selectedValue : '3'} | ||
| </DropdownToggle> | ||
| } | ||
| name="controlPlaneAgents" |
There was a problem hiding this comment.
Is it controlPlaneAgents (here) or controlPlaneCount (in the form object type). I think the mix up causes some issues.
Especially after the cluster is created.
Related to stolostron/console#4146