When the provider assumes a given role, don't use the default profile… #87

massimob76 · 2023-09-25T16:22:40Z

… if the profile is not given, but allow aws-sdk-go to find the credentials using the default credential provider chain (#86)

Description

When aws_assume_role_arn is given but no aws_profile, it won't set the profile to default but it will let the aws-sdk-go library to find out the credentials using the default provider chain.
When aws_assume_role_arn is given as well as aws_profile, it won't change its current behaviour and the aws-sdk-go library will use the given profile.

Issues Resolved

This will revolve issue #86

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… if the profile is not given, but allow aws-sdk-go to find the credentials using the default credential provider chain (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]>

prudhvigodithi · 2023-10-05T19:41:42Z

Thanks @massimob76 this looks good, any unit tests can be added?

prudhvigodithi · 2023-10-09T15:06:00Z

Hey @massimob76 just following back, can you please add some unit tests so that we can move forward with this PR?
Thank you

massimob76 · 2023-10-16T10:40:05Z

hi @prudhvigodithi I will try to add some unit tests this week, sorry I have been very busy lately.

massimob76 · 2023-10-26T12:30:48Z

Hi @prudhvigodithi, I have added some tests - that required a few changes:

added a mock server for intercepting the api call rather than the real AWS endpoint. Only during tests we use a mock server endpoint when calling awsSession, otherwise endpoint="" which will lead to aws-sdk-go to call its real endpoint.
swapped the test_aws_config with the test_aws_credentials since when running it locally if a credentials file exists it will have the priority over the test_aws_config fixture. But using test_aws_credentials instead will remove any interference from the local setup.

Signed-off-by: Massimo Battestini <[email protected]>

prudhvigodithi · 2023-11-01T21:03:16Z

Thanks @massimob76 for your contribution, merging the PR now.

andrejvanderzee · 2023-11-02T15:51:53Z

Any ETA on releasing this now that it is merged?

opensearch-project#87) * When the provider assumes a given role, don't use the default profile if the profile is not given, but allow aws-sdk-go to find the credentials using the default credential provider chain (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> * Adds unit tests for AWS profile change (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> --------- Signed-off-by: Massimo Battestini <[email protected]> Signed-off-by: Aaron Miller <[email protected]>

opensearch-project#87) * When the provider assumes a given role, don't use the default profile if the profile is not given, but allow aws-sdk-go to find the credentials using the default credential provider chain (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> * Adds unit tests for AWS profile change (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> --------- Signed-off-by: Massimo Battestini <[email protected]>

estebane-frb · 2023-11-07T20:26:35Z

Any chance this can be released soon? This has been a big blocker for us to be able to use the provider.

justinhauer · 2023-11-07T21:08:45Z

@prudhvigodithi can you give us any type of time frame when you think this will be released?

prudhvigodithi · 2023-11-08T03:31:11Z

Hey @estebane-frb @justinhauer I have an issue created for this purpose #122, I'm planning to go ahead with the release tomorrow (PST), just waiting on one feature PR to support OpenSearch serverless to go in #92, thank you for your patience.
Adding @vasyaxparfenov @bbarani

prudhvigodithi · 2023-11-08T17:47:05Z

The provider v2.1.0 has been released, please check.
Provider Download link: https://registry.terraform.io/providers/opensearch-project/opensearch/2.1.0

Signed-off-by: Aaron Miller <[email protected]> Add anomaly detection (opensearch-project#105) * Add anomaly detection Signed-off-by: Rupa Lahiri <[email protected]> * Add test for update Signed-off-by: Rupa Lahiri <[email protected]> * Add audit config in anomaly detector test Signed-off-by: Rupa Lahiri <[email protected]> * Format terraform in test Signed-off-by: Rupa Lahiri <[email protected]> --------- Signed-off-by: Rupa Lahiri <[email protected]> Signed-off-by: Aaron Miller <[email protected]> When the provider assumes a given role, don't use the default profile… (opensearch-project#87) * When the provider assumes a given role, don't use the default profile if the profile is not given, but allow aws-sdk-go to find the credentials using the default credential provider chain (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> * Adds unit tests for AWS profile change (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> --------- Signed-off-by: Massimo Battestini <[email protected]> Signed-off-by: Aaron Miller <[email protected]> Add step to generate terraform provider documentation by running tfplugindocs (opensearch-project#120) Signed-off-by: Rupa Lahiri <[email protected]> Signed-off-by: Aaron Miller <[email protected]> Improve documentation for HTTP basic authentication (opensearch-project#114) * Update template Signed-off-by: Jason Parraga <[email protected]> * Generate docs using tfplugindocs Signed-off-by: Jason Parraga <[email protected]> --------- Signed-off-by: Jason Parraga <[email protected]> Signed-off-by: Aaron Miller <[email protected]> fix complaints in errcheck linter Signed-off-by: Aaron Miller <[email protected]> Add proxy support (opensearch-project#95) * Add proxy support Add a new optional parameter to the provider configuration to allow for setting a proxy. Using a proxy can be an easier method for connecting to clusters within a VPC. Signed-off-by: Tim Wisbauer <[email protected]> * Add proxy support docs Signed-off-by: Tim Wisbauer <[email protected]> --------- Signed-off-by: Tim Wisbauer <[email protected]> Add anomaly detection (opensearch-project#105) * Add anomaly detection Signed-off-by: Rupa Lahiri <[email protected]> * Add test for update Signed-off-by: Rupa Lahiri <[email protected]> * Add audit config in anomaly detector test Signed-off-by: Rupa Lahiri <[email protected]> * Format terraform in test Signed-off-by: Rupa Lahiri <[email protected]> --------- Signed-off-by: Rupa Lahiri <[email protected]> When the provider assumes a given role, don't use the default profile… (opensearch-project#87) * When the provider assumes a given role, don't use the default profile if the profile is not given, but allow aws-sdk-go to find the credentials using the default credential provider chain (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> * Adds unit tests for AWS profile change (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> --------- Signed-off-by: Massimo Battestini <[email protected]> Add step to generate terraform provider documentation by running tfplugindocs (opensearch-project#120) Signed-off-by: Rupa Lahiri <[email protected]> Improve documentation for HTTP basic authentication (opensearch-project#114) * Update template Signed-off-by: Jason Parraga <[email protected]> * Generate docs using tfplugindocs Signed-off-by: Jason Parraga <[email protected]> --------- Signed-off-by: Jason Parraga <[email protected]> Add proxy support (opensearch-project#95) * Add proxy support Add a new optional parameter to the provider configuration to allow for setting a proxy. Using a proxy can be an easier method for connecting to clusters within a VPC. Signed-off-by: Tim Wisbauer <[email protected]> * Add proxy support docs Signed-off-by: Tim Wisbauer <[email protected]> --------- Signed-off-by: Tim Wisbauer <[email protected]> Add anomaly detection (opensearch-project#105) * Add anomaly detection Signed-off-by: Rupa Lahiri <[email protected]> * Add test for update Signed-off-by: Rupa Lahiri <[email protected]> * Add audit config in anomaly detector test Signed-off-by: Rupa Lahiri <[email protected]> * Format terraform in test Signed-off-by: Rupa Lahiri <[email protected]> --------- Signed-off-by: Rupa Lahiri <[email protected]> Improve documentation for HTTP basic authentication (opensearch-project#114) * Update template Signed-off-by: Jason Parraga <[email protected]> * Generate docs using tfplugindocs Signed-off-by: Jason Parraga <[email protected]> --------- Signed-off-by: Jason Parraga <[email protected]> Add proxy support (opensearch-project#95) * Add proxy support Add a new optional parameter to the provider configuration to allow for setting a proxy. Using a proxy can be an easier method for connecting to clusters within a VPC. Signed-off-by: Tim Wisbauer <[email protected]> * Add proxy support docs Signed-off-by: Tim Wisbauer <[email protected]> --------- Signed-off-by: Tim Wisbauer <[email protected]>

massimob76 requested review from peterzhuamazon, prudhvigodithi, jackson-theisen and phillbaker as code owners September 25, 2023 16:22

massimob76 force-pushed the main branch from c0d34fe to 5e5623f Compare September 25, 2023 16:25

When the provider assumes a given role, don't use the default profile…

b113bb3

… if the profile is not given, but allow aws-sdk-go to find the credentials using the default credential provider chain (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]>

massimob76 force-pushed the main branch from 5e5623f to b113bb3 Compare September 25, 2023 16:35

massimob76 mentioned this pull request Oct 5, 2023

[BUG] #61

Open

vasyaxparfenov mentioned this pull request Oct 19, 2023

added opensearch serverless support #92

Merged

massimob76 force-pushed the main branch from 6ec75c5 to e1b7494 Compare October 26, 2023 09:33

Adds unit tests for AWS profile change (opensearch-project#86)

7c61d11

Signed-off-by: Massimo Battestini <[email protected]>

massimob76 force-pushed the main branch from e1b7494 to 7c61d11 Compare October 26, 2023 12:40

massimob76 mentioned this pull request Oct 26, 2023

[BUG] Environment variable AWS_PROFILE, AWS_ACCESS_KEY_ID and AWS_ACCES_KEY not respected with aws_assume_role_arn #99

Open

prudhvigodithi approved these changes Nov 1, 2023

View reviewed changes

prudhvigodithi merged commit 0cfc9f2 into opensearch-project:main Nov 1, 2023
5 checks passed

prudhvigodithi mentioned this pull request Nov 5, 2023

[BUG] Error: invalid character 'U' looking for beginning of value when basic auth credentials are incorrect #115

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When the provider assumes a given role, don't use the default profile… #87

When the provider assumes a given role, don't use the default profile… #87

massimob76 commented Sep 25, 2023

prudhvigodithi commented Oct 5, 2023

prudhvigodithi commented Oct 9, 2023

massimob76 commented Oct 16, 2023

massimob76 commented Oct 26, 2023

prudhvigodithi commented Nov 1, 2023

andrejvanderzee commented Nov 2, 2023

estebane-frb commented Nov 7, 2023

justinhauer commented Nov 7, 2023

prudhvigodithi commented Nov 8, 2023 •

edited

Loading

prudhvigodithi commented Nov 8, 2023

When the provider assumes a given role, don't use the default profile… #87

When the provider assumes a given role, don't use the default profile… #87

Conversation

massimob76 commented Sep 25, 2023

Description

Issues Resolved

prudhvigodithi commented Oct 5, 2023

prudhvigodithi commented Oct 9, 2023

massimob76 commented Oct 16, 2023

massimob76 commented Oct 26, 2023

prudhvigodithi commented Nov 1, 2023

andrejvanderzee commented Nov 2, 2023

estebane-frb commented Nov 7, 2023

justinhauer commented Nov 7, 2023

prudhvigodithi commented Nov 8, 2023 • edited Loading

prudhvigodithi commented Nov 8, 2023

prudhvigodithi commented Nov 8, 2023 •

edited

Loading