Fix aws authentication issues with assume role #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set profile to default when using assume role and user doesnt pass Role name Update aws sdk to version opensearch-project#64 Signed-off-by: Kirmayer Elad <[email protected]>
ekirmayer
requested review from
peterzhuamazon,
prudhvigodithi,
jackson-theisen and
phillbaker
as code owners
|
Hey @ekirmayer thanks for your contribution, the CI checks failed, please try to address them. Thanks |
https://github.com/golangci/golangci-lint-action#compatibility Signed-off-by: Kirmayer Elad <[email protected]>
|
@prudhvigodithi i've updated the linter version as the issue is there from what i can find |
prudhvigodithi
approved these changes
Sep 11, 2023
|
Thanks @ekirmayer. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix require Externald when not needed #61
Set profile to default when using assume role and user doesnt pass Role name
Update aws sdk to version #64
Issues Resolved
#61
#64
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.