Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): improve OpenSearch spelling #140

Conversation

etolbakov
Copy link
Contributor

Description

Renaming to address spelling issues with OpenSearch

Issues Resolved

#139

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@etolbakov etolbakov force-pushed the etolbakov/improve-opensearch-spelling branch from eb3490c to 9570670 Compare December 22, 2023 19:47
@etolbakov
Copy link
Contributor Author

Hello @dblock could you please take a look when you have time?

@prudhvigodithi
Copy link
Member

Hey @etolbakov thanks for your contribution, I will very soon review this PR, thanks.

@prudhvigodithi
Copy link
Member

LGTM!

@prudhvigodithi prudhvigodithi merged commit 15ede3a into opensearch-project:main Dec 22, 2023
5 checks passed
@etolbakov
Copy link
Contributor Author

Thank you @prudhvigodithi for a quick turnaround!

@etolbakov etolbakov deleted the etolbakov/improve-opensearch-spelling branch December 22, 2023 20:04
@prudhvigodithi
Copy link
Member

@etolbakov can you please backport this to 1.x branch ?

@prudhvigodithi prudhvigodithi added the backport 1.x Backport to 1.x branch after merging to main label Dec 22, 2023
@etolbakov
Copy link
Contributor Author

Just to confirm by backport you mean applying the same set of changes to the 1.x branch right?
If that's the case, sure will do that

@prudhvigodithi
Copy link
Member

Yes you are right, update the same changes for 1.x branch.

@etolbakov
Copy link
Contributor Author

etolbakov commented Dec 22, 2023

Made the backport in #141
@prudhvigodithi I see that tests have failed after the changes from current PR were merged in the main.
Is there something I've overlooked?

prudhvigodithi pushed a commit to prudhvigodithi/terraform-provider-opensearch that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x Backport to 1.x branch after merging to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants