Fix persistent delete of config_id (88) #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afrodidact
requested review from
peterzhuamazon,
prudhvigodithi,
jackson-theisen and
phillbaker
as code owners
|
Hey @afrodidact can you please add some tests for this change? |
|
Hi @prudhvigodithi, thanks for letting me know I missed the unit tests. I haven't read that part of the code yet, so I will take some time over the coming days to familiarise myself with them, then alert you when I make my next commit. |
|
Hey @afrodidact can you please update the PR with some unit tests? we can proceed to merge this PR. |
|
Hi @prudhvigodithi, yes sorry for the delay. I am working on the unit tests and will try to update this soon. |
Signed-off-by: Aaron Miller <[email protected]>
* Add anomaly detection Signed-off-by: Rupa Lahiri <[email protected]> * Add test for update Signed-off-by: Rupa Lahiri <[email protected]> * Add audit config in anomaly detector test Signed-off-by: Rupa Lahiri <[email protected]> * Format terraform in test Signed-off-by: Rupa Lahiri <[email protected]> --------- Signed-off-by: Rupa Lahiri <[email protected]> Signed-off-by: Aaron Miller <[email protected]>
opensearch-project#87) * When the provider assumes a given role, don't use the default profile if the profile is not given, but allow aws-sdk-go to find the credentials using the default credential provider chain (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> * Adds unit tests for AWS profile change (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> --------- Signed-off-by: Massimo Battestini <[email protected]> Signed-off-by: Aaron Miller <[email protected]>
…ugindocs (opensearch-project#120) Signed-off-by: Rupa Lahiri <[email protected]> Signed-off-by: Aaron Miller <[email protected]>
…ct#114) * Update template Signed-off-by: Jason Parraga <[email protected]> * Generate docs using tfplugindocs Signed-off-by: Jason Parraga <[email protected]> --------- Signed-off-by: Jason Parraga <[email protected]> Signed-off-by: Aaron Miller <[email protected]>
Signed-off-by: Aaron Miller <[email protected]>
afrodidact
force-pushed
the
bugfix/opensearch-channel-configuration-config-id
branch
from
b7e5dd1
to
a747197
Compare
* Add proxy support Add a new optional parameter to the provider configuration to allow for setting a proxy. Using a proxy can be an easier method for connecting to clusters within a VPC. Signed-off-by: Tim Wisbauer <[email protected]> * Add proxy support docs Signed-off-by: Tim Wisbauer <[email protected]> --------- Signed-off-by: Tim Wisbauer <[email protected]>
…-configuration-config-id
* Add anomaly detection Signed-off-by: Rupa Lahiri <[email protected]> * Add test for update Signed-off-by: Rupa Lahiri <[email protected]> * Add audit config in anomaly detector test Signed-off-by: Rupa Lahiri <[email protected]> * Format terraform in test Signed-off-by: Rupa Lahiri <[email protected]> --------- Signed-off-by: Rupa Lahiri <[email protected]>
opensearch-project#87) * When the provider assumes a given role, don't use the default profile if the profile is not given, but allow aws-sdk-go to find the credentials using the default credential provider chain (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> * Adds unit tests for AWS profile change (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> --------- Signed-off-by: Massimo Battestini <[email protected]>
…ct#114) * Update template Signed-off-by: Jason Parraga <[email protected]> * Generate docs using tfplugindocs Signed-off-by: Jason Parraga <[email protected]> --------- Signed-off-by: Jason Parraga <[email protected]>
* Add proxy support Add a new optional parameter to the provider configuration to allow for setting a proxy. Using a proxy can be an easier method for connecting to clusters within a VPC. Signed-off-by: Tim Wisbauer <[email protected]> * Add proxy support docs Signed-off-by: Tim Wisbauer <[email protected]> --------- Signed-off-by: Tim Wisbauer <[email protected]>
Signed-off-by: Aaron Miller <[email protected]> Add anomaly detection (opensearch-project#105) * Add anomaly detection Signed-off-by: Rupa Lahiri <[email protected]> * Add test for update Signed-off-by: Rupa Lahiri <[email protected]> * Add audit config in anomaly detector test Signed-off-by: Rupa Lahiri <[email protected]> * Format terraform in test Signed-off-by: Rupa Lahiri <[email protected]> --------- Signed-off-by: Rupa Lahiri <[email protected]> Signed-off-by: Aaron Miller <[email protected]> When the provider assumes a given role, don't use the default profile… (opensearch-project#87) * When the provider assumes a given role, don't use the default profile if the profile is not given, but allow aws-sdk-go to find the credentials using the default credential provider chain (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> * Adds unit tests for AWS profile change (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> --------- Signed-off-by: Massimo Battestini <[email protected]> Signed-off-by: Aaron Miller <[email protected]> Add step to generate terraform provider documentation by running tfplugindocs (opensearch-project#120) Signed-off-by: Rupa Lahiri <[email protected]> Signed-off-by: Aaron Miller <[email protected]> Improve documentation for HTTP basic authentication (opensearch-project#114) * Update template Signed-off-by: Jason Parraga <[email protected]> * Generate docs using tfplugindocs Signed-off-by: Jason Parraga <[email protected]> --------- Signed-off-by: Jason Parraga <[email protected]> Signed-off-by: Aaron Miller <[email protected]> fix complaints in errcheck linter Signed-off-by: Aaron Miller <[email protected]> Add proxy support (opensearch-project#95) * Add proxy support Add a new optional parameter to the provider configuration to allow for setting a proxy. Using a proxy can be an easier method for connecting to clusters within a VPC. Signed-off-by: Tim Wisbauer <[email protected]> * Add proxy support docs Signed-off-by: Tim Wisbauer <[email protected]> --------- Signed-off-by: Tim Wisbauer <[email protected]> Add anomaly detection (opensearch-project#105) * Add anomaly detection Signed-off-by: Rupa Lahiri <[email protected]> * Add test for update Signed-off-by: Rupa Lahiri <[email protected]> * Add audit config in anomaly detector test Signed-off-by: Rupa Lahiri <[email protected]> * Format terraform in test Signed-off-by: Rupa Lahiri <[email protected]> --------- Signed-off-by: Rupa Lahiri <[email protected]> When the provider assumes a given role, don't use the default profile… (opensearch-project#87) * When the provider assumes a given role, don't use the default profile if the profile is not given, but allow aws-sdk-go to find the credentials using the default credential provider chain (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> * Adds unit tests for AWS profile change (opensearch-project#86) Signed-off-by: Massimo Battestini <[email protected]> --------- Signed-off-by: Massimo Battestini <[email protected]> Add step to generate terraform provider documentation by running tfplugindocs (opensearch-project#120) Signed-off-by: Rupa Lahiri <[email protected]> Improve documentation for HTTP basic authentication (opensearch-project#114) * Update template Signed-off-by: Jason Parraga <[email protected]> * Generate docs using tfplugindocs Signed-off-by: Jason Parraga <[email protected]> --------- Signed-off-by: Jason Parraga <[email protected]> Add proxy support (opensearch-project#95) * Add proxy support Add a new optional parameter to the provider configuration to allow for setting a proxy. Using a proxy can be an easier method for connecting to clusters within a VPC. Signed-off-by: Tim Wisbauer <[email protected]> * Add proxy support docs Signed-off-by: Tim Wisbauer <[email protected]> --------- Signed-off-by: Tim Wisbauer <[email protected]> Add anomaly detection (opensearch-project#105) * Add anomaly detection Signed-off-by: Rupa Lahiri <[email protected]> * Add test for update Signed-off-by: Rupa Lahiri <[email protected]> * Add audit config in anomaly detector test Signed-off-by: Rupa Lahiri <[email protected]> * Format terraform in test Signed-off-by: Rupa Lahiri <[email protected]> --------- Signed-off-by: Rupa Lahiri <[email protected]> Improve documentation for HTTP basic authentication (opensearch-project#114) * Update template Signed-off-by: Jason Parraga <[email protected]> * Generate docs using tfplugindocs Signed-off-by: Jason Parraga <[email protected]> --------- Signed-off-by: Jason Parraga <[email protected]> Add proxy support (opensearch-project#95) * Add proxy support Add a new optional parameter to the provider configuration to allow for setting a proxy. Using a proxy can be an easier method for connecting to clusters within a VPC. Signed-off-by: Tim Wisbauer <[email protected]> * Add proxy support docs Signed-off-by: Tim Wisbauer <[email protected]> --------- Signed-off-by: Tim Wisbauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes a bug where the
config_idattribute was lost during the plan/diff phase even after being set correctly in the Read method. I have now fixed the issue by extracting theconfig_idvalue from the API response to a temporary variable before setting the state. This avoids the issue caused by setting the state directly from the complex API response struct.The fix ensures that the
config_idproperty is correctly persisted in the resource state between plans. Additionally, I have included optional handling for thebodyattribute if defined in the schema to avoid hardcoding assumptions about the schema structure.Issues Resolved
Closes [#88].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.