Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup - ppl command #3181

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

Lookup - ppl command #3181

wants to merge 25 commits into from

Conversation

YANG-DB
Copy link
Member

@YANG-DB YANG-DB commented Dec 2, 2024

Description

Continuing the lookup command PR done by @lukasz-soszynski-eliatra

Related Issues

#2651

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

salyh and others added 17 commits July 16, 2024 13:11
Signed-off-by: Hendrik Saly <[email protected]>
Signed-off-by: Hendrik Saly <[email protected]>
Signed-off-by: Hendrik Saly <[email protected]>
Signed-off-by: Lukasz Soszynski <[email protected]>
Signed-off-by: Hendrik Saly <[email protected]>

Fix typo

Signed-off-by: Hendrik Saly <[email protected]>
Signed-off-by: Lukasz Soszynski <[email protected]>
Signed-off-by: Hendrik Saly <[email protected]>
# Conflicts:
#	integ-test/src/test/java/org/opensearch/sql/legacy/SQLIntegTestCase.java
#	integ-test/src/test/java/org/opensearch/sql/legacy/TestsConstants.java
#	opensearch/src/test/java/org/opensearch/sql/opensearch/storage/OpenSearchIndexTest.java
@YANG-DB
Copy link
Member Author

YANG-DB commented Dec 3, 2024

@penghuo
I'm continuing the ppl lookup command implementation and wanted to ask about your comment for performance testing:

  • where can I perform the tests ? - can you please refer me to another performance test example ?
  • what criteria would we consider as reasonable performance
  • what kind of user warning documentation should we add to the command regarding its performance limits recommendations

# Conflicts:
#	core/src/main/java/org/opensearch/sql/ast/dsl/AstDSL.java
# Conflicts:
#	core/src/test/java/org/opensearch/sql/analysis/AnalyzerTest.java
#	core/src/test/java/org/opensearch/sql/executor/ExplainTest.java
#	core/src/test/java/org/opensearch/sql/planner/logical/LogicalPlanNodeVisitorTest.java
#	core/src/test/java/org/opensearch/sql/planner/physical/PhysicalPlanNodeVisitorTest.java
#	ppl/src/test/java/org/opensearch/sql/ppl/parser/AstBuilderTest.java
#	ppl/src/test/java/org/opensearch/sql/ppl/utils/PPLQueryDataAnonymizerTest.java
@YANG-DB YANG-DB marked this pull request as draft December 13, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants