Add grammar validation for PPL #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykmr1224
force-pushed
the
ppl-validation
branch
3 times, most recently
from
7436099 to
e7ec01c
Compare
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
force-pushed
the
ppl-validation
branch
from
d033694 to
9e4d2eb
Compare
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
LantaoJin and
noCharger
as code owners
dai-chen
reviewed
Nov 26, 2024
We added validator only for SQL, not PPL yet. |
seankao-az
approved these changes
Nov 26, 2024
dai-chen
approved these changes
Nov 26, 2024
|
Triggering CI again. Not sure if the CI failure is transient. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Add grammar validation for PPL Signed-off-by: Tomoyuki Morita <[email protected]> * Remove specific PPL grammar validator Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit 871d9f2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Add grammar validation for PPL * Remove specific PPL grammar validator --------- (cherry picked from commit 871d9f2) Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
n/a
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.