Update grammar validation settings #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
added
backport 2.x
maintenance
ykmr1224
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
LantaoJin and
noCharger
as code owners
dai-chen
approved these changes
Nov 20, 2024
| @@ -561,12 +561,18 @@ private void validateFunctionAllowed(String function) { | |||
| case MAP: | |||
| validateAllowed(GrammarElement.MAP_FUNCTIONS); | |||
| break; | |||
| case BITWISE: | |||
There was a problem hiding this comment.
so we need to keep adding case and there is no way to convert function to grammar element?
There was a problem hiding this comment.
We can have a map if we want. Let me try that approach.
There was a problem hiding this comment.
Let me go ahead with the current approach for now, I found some test case conflict if I enable validation for all the function types.
noCharger
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
the PR content lgtm. there are some code refactor like #3165 (comment)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit 8b2d01e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224
pushed a commit
that referenced
this pull request
Nov 21, 2024
(cherry picked from commit 8b2d01e) Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
n/a
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.