Call LeaseManager for BatchQuery

[ykmr1224]

Description

• Call LeaseManager for BatchQuery
  • Currently, LeaseManager.borrow is not called for BatchQuery

Related Issues

n/a

Check List

• New functionality includes testing.
• New functionality has been documented.
• New functionality has javadoc added.
• New functionality has a user manual doc added.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (cfe38d7) to head (dba09c4).

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #3153   +/-   ##
=========================================
  Coverage     94.48%   94.48%           
- Complexity     5426     5428    +2     
=========================================
  Files           528      528           
  Lines         15452    15456    +4     
  Branches       1025     1025           
=========================================
+ Hits          14600    14604    +4     
  Misses          804      804           
  Partials         48       48           

Flag	Coverage Δ
sql-engine	94.48% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ykmr1224]

CI failure is due to coverage caused by: #3063

[noCharger]

High level questions

1. Does the current class model meet the requirements for extending to another implementation?

sql/async-query/src/main/java/org/opensearch/sql/spark/transport/config/AsyncExecutorServiceModule.java

Lines 230 to 232 in cfe38d7

	public DefaultLeaseManager defaultLeaseManager(Settings settings, StateStore stateStore) {
	return new DefaultLeaseManager(settings, stateStore);
	}

2. Will this code change to BatchQueryHandler and RefreshQueryHandler affect the present logic of examining ConcurrentRefreshJobRule?

[ykmr1224]

1. Does the current class model meet the requirements for extending to another implementation?

sql/async-query/src/main/java/org/opensearch/sql/spark/transport/config/AsyncExecutorServiceModule.java

Lines 230 to 232 in cfe38d7

	public DefaultLeaseManager defaultLeaseManager(Settings settings, StateStore stateStore) {
	return new DefaultLeaseManager(settings, stateStore);
	}

Yes, DQS will internally check running jobs and limit new execution.

2. Will this code change to BatchQueryHandler and RefreshQueryHandler affect the present logic of examining ConcurrentRefreshJobRule?

It won't affect. I excluded Batch query from ConcurrentRefreshJobRule.

[dai-chen]

Could you elaborate a little what was the issue?

[ykmr1224]

Could you elaborate a little what was the issue?

DQS couldn't cover the Batch query to avoid too many concurrent execution.