Code

Add CIDR function to PPL (#3036)#3110

Code

Merged

acarbonetto merged 40 commits intoopensearch-project:mainopensearch-project/sql:mainfrom Bit-Quill:opensearch-3036Bit-Quill/opensearch-project-sql:opensearch-3036Copy head branch name to clipboardDec 3, 2024

+623-254

Commits

Commits on Oct 31, 2024

• Add stub implementation of cidr:

  Show description for bd264a0
  currantw

  committed
  bd264a0

• Initial implementation of isAddressInRange method.

  Show description for c2ecdf7
  currantw

  committed
  c2ecdf7

• Add BinaryPredicateOperator tests for cidr. Update isAddressInRange implementation to return false rather than raising an exception.

  Show description for bfcbbf5
  currantw

  committed
  bfcbbf5

• Fix a couple documentation typos.

  Show description for 093696a
  currantw

  committed
  093696a

• Add documentation for cidr function.

  Show description for f0464d3
  currantw

  committed
  f0464d3

• Add documentation for cidr function.

  Show description for ce8d190
  currantw

  committed
  ce8d190

• Add license header to IPUtils.

  Show description for 6d56ac9
  currantw

  committed
  6d56ac9

• Revert final and toString cleanup.

  Show description for 96aaa89
  currantw

  committed
  96aaa89

• Update to use CidrExpression:

  Show description for 04af98d
  currantw

  committed
  04af98d

• Refactor to replace CidrExpression with IPFunctions. Plus preliminary implementation of integration tests (currently failing).

  Show description for f2ca434
  currantw

  committed
  f2ca434

• Address review comments - minor code cleanup.

  Show description for efe26b8
  currantw

  committed
  efe26b8

• Fix failing IPFunction unit tests.

  Show description for 824c463
  currantw

  committed
  824c463

• Reformat new files with Spotless.

  Show description for 3ffac2e
  currantw

  committed
  3ffac2e

• Fix typos in UnaryPredicateOperator.

  Show description for 128bb4b
  currantw

  committed
  128bb4b

• Rename cidr to cidrmatch for consistency with Spark (see issue opensearch-project#706).

  Show description for 3f267a7
  currantw

  committed
  3f267a7

• Minor documentation to better align with Spark cidrmatch behaviour.

  Show description for d473fc7
  currantw

  committed
  d473fc7

• Refactor implementation to use com.github.seancfoley:ipaddress:5.4.2 (already a dependency for :core) and to match behaviour in Spark.

  Show description for 9ba705a
  currantw

  committed
  9ba705a

• Update OpenSearchIpType to covert to string type.

  Show description for c95152e
  currantw

  committed
  c95152e

• Run Spotless.

  Show description for 9c7f5b6
  currantw

  committed
  9c7f5b6

• Minor cleanup.

  Show description for b7fb7f7
  currantw

  committed
  b7fb7f7

• Update typos to fix failing unit tests, plus run Spotless.

  Show description for 4b60ae1
  currantw

  committed
  4b60ae1

• Fix remaining failing unit tests.

  Show description for 08af013
  currantw

  committed
  08af013

Commits on Nov 7, 2024

• Address minor review comments.

  Show description for 4b05c24
  currantw

  committed
  4b05c24

• Apply Spotless

  Show description for 17decc8
  currantw

  committed
  17decc8

• Cleanup: remove a few redundant local variables.

  Show description for e8b6f4e
  currantw

  committed
  e8b6f4e

Commits on Nov 8, 2024

• More Spotless

  Show description for ac02e67
  currantw

  committed
  ac02e67

• Add missing unit test

  Show description for 8c17404
  currantw

  committed
  8c17404

Commits on Nov 12, 2024

• Get rid of wildcard imports.

  Show description for 20c9672
  currantw

  committed
  20c9672

• Fix more wildcard import statements

  Show description for fb0be94
  currantw

  committed
  fb0be94

• Add miss test data for doctest

  Show description for 3af85af
  currantw

  committed
  3af85af

Commits on Nov 13, 2024

• Fix some more failing integration tests

  Show description for aa9cb85
  currantw

  committed
  aa9cb85

Commits on Nov 14, 2024

• Fix failing doc test

  Show description for cff2418
  currantw

  committed
  cff2418

Commits on Nov 19, 2024

• Address minor review comments.

  Show description for 8324c4c
  currantw

  committed
  8324c4c

Commits on Nov 21, 2024

• Revert changes to cast IP to string.

  Show description for e758077
  currantw

  committed
  e758077

Commits on Nov 22, 2024

• Fix failing tests and add TODOs for opensearch-project#3145 (add support for IP address type).

  Show description for 677bdc8
  currantw

  committed
  677bdc8

Commits on Nov 28, 2024

• Update ip.rst for consistency with Spark

  Show description for 43d05d6
  currantw

  committed
  43d05d6

• Update ip.rst for consistency with Spark

  Show description for 23219cb
  currantw

  committed
  23219cb

Commits on Dec 2, 2024

• Rename "function" and "operator" utility classes to be plural.

  Show description for d3be058
  currantw

  committed
  d3be058

• Minor documentation updates

  Show description for c216763
  currantw

  committed
  c216763

• Apply spotless

  Show description for 1b608c6
  currantw

  committed
  1b608c6