[Backport 2.x] IF function should support complex predicates in PPL #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect#2756) Signed-off-by: Lantao Jin <[email protected]> (cherry picked from commit 593ffab)
LantaoJin
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG and
ykmr1224
as code owners
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
changed the title
IF function in PPL
|
Manually submit a PR since auto backport failed: #2756 (comment) |
|
Tests all passed. Failures of backward compatibility are not related to this PR. |
|
@LantaoJin we never backport feature/bug fix to patch version. Per OpenSearch feature branches guideline |
penghuo
approved these changes
Sep 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
Signed-off-by: Lantao Jin <[email protected]> (cherry picked from commit 593ffab) Signed-off-by: Lantao Jin <[email protected]> (cherry picked from commit 1e95b68) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
seankao-az
pushed a commit
that referenced
this pull request
Sep 4, 2024
…2970) (cherry picked from commit 593ffab) (cherry picked from commit 1e95b68) Signed-off-by: Lantao Jin <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 593ffab from #2756