Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Updating Grammer changes same as main branch #2850

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

manasvinibs
Copy link
Member

Description

Grammer updates similar to main changes https://github.com/opensearch-project/sql/pull/2787/files#diff-904696434b9388edb2a76068319116b53a614972861839145af96cb216d323be

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rupal-bq rupal-bq merged commit b1904e0 into opensearch-project:2.x Jul 23, 2024
26 of 27 checks passed
@dai-chen
Copy link
Collaborator

dai-chen commented Jul 23, 2024

@manasvinibs I'm drafting release notes for 2.16. Does this need to back port to 2.16?

@manasvinibs
Copy link
Member Author

@dai-chen yes can we backport this PR and #2849 to 2.16 if it is still possible?

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
Signed-off-by: Manasvini B S <[email protected]>
(cherry picked from commit b1904e0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224 pushed a commit that referenced this pull request Jul 24, 2024
(cherry picked from commit b1904e0)

Signed-off-by: Manasvini B S <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.16 v2.16.0 Issues targeting release v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants