Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MacOS from workflow #2825

Closed

Conversation

ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Jul 12, 2024

Description

Issues Resolved

  • workflow failure

Check List

  • [-] New functionality includes testing.
    • [-] All tests pass, including unit test, integration test and doctest
  • [-] New functionality has been documented.
    • [-] New functionality has javadoc added
    • [-] New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tomoyuki Morita <[email protected]>
@ykmr1224 ykmr1224 marked this pull request as ready for review July 12, 2024 23:58
@ykmr1224 ykmr1224 added the maintenance Improves code quality, but not the product label Jul 12, 2024
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.62%. Comparing base (9c2b01d) to head (359b02c).

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x    #2825   +/-   ##
=========================================
  Coverage     94.62%   94.62%           
  Complexity     5095     5095           
=========================================
  Files           503      503           
  Lines         14555    14555           
  Branches        949      949           
=========================================
  Hits          13773    13773           
  Misses          740      740           
  Partials         42       42           
Flag Coverage Δ
sql-engine 94.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, macos is removed #2662 (comment), says "artifacts are not available and those tests will always fail."

  1. What artifact is not available? Is there a known issue with this? The reason I'm asking is that I didn't see an organization-wide issue on this problem.
  2. What is the failed test? Should we mark them as flaky tests and fix them?

@ykmr1224
Copy link
Collaborator Author

Just curious, macos is removed #2662 (comment), says "artifacts are not available and those tests will always fail."

  1. What artifact is not available? Is there a known issue with this? The reason I'm asking is that I didn't see an organization-wide issue on this problem.
  2. What is the failed test? Should we mark them as flaky tests and fix them?

Here is the error:

* What went wrong:
Execution failed for task ':doctest:runRestTestCluster'.
> Could not resolve all files for configuration ':doctest:opensearch_distro_extracted_testclusters-doctest-docTestCluster-0-2.16.0-SNAPSHOT-'.
   > Could not resolve opensearch-distribution-snapshot:opensearch:2.16.0-SNAPSHOT.
     Required by:
         project :doctest
      > Could not resolve opensearch-distribution-snapshot:opensearch:2.16.0-SNAPSHOT.
         > Could not get resource 'https://artifacts.opensearch.org/snapshots/core/opensearch/2.16.0-SNAPSHOT/opensearch-min-2.16.0-SNAPSHOT-darwin-arm64-latest.tar.gz'.
            > Could not HEAD 'https://artifacts.opensearch.org/snapshots/core/opensearch/2.16.0-SNAPSHOT/opensearch-min-2.16.0-SNAPSHOT-darwin-arm64-latest.tar.gz'. Received status code 403 from server: Forbidden

2 -> I'm not sure if we should spend time to fix the issue if we don't support macOS. Any thoughts?

@LantaoJin
Copy link
Member

Close this since #2830 fixed the build issue and merged.

@LantaoJin LantaoJin closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improves code quality, but not the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants