Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude integ-test and download task when built offline #2760

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Jun 18, 2024

Description

  • Exclude integ-test, doctest and download task when built offline
  • This is to make async-query-core module buildable in offline environment (it still requires Gradle cache)
  • When built with --offline option, integ-test and doctest will be excluded, and also download of .g4 files are skipped. Even if we specify target such as :async-query-core:shadowJar, some downloads were done during preparation, and build failed even though async-query-core module does not depend on integ-test.

Issues Resolved

n/a

Check List

  • [n/a] New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • [n/a] New functionality has javadoc added
    • [n/a] New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ykmr1224 ykmr1224 added backport 2.x maintenance Improves code quality, but not the product labels Jun 18, 2024
@ykmr1224 ykmr1224 merged commit 07e52d9 into opensearch-project:main Jun 19, 2024
12 of 20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 19, 2024
Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit 07e52d9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224 pushed a commit that referenced this pull request Jun 19, 2024
…) (#2763)

(cherry picked from commit 07e52d9)

Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ykmr1224 ykmr1224 deleted the offline-build branch June 19, 2024 04:23
jzonthemtn pushed a commit to jzonthemtn/sql that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x maintenance Improves code quality, but not the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants