Abstract metrics to reduce dependency to legacy #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykmr1224
added
backport 2.x
maintenance
ykmr1224
force-pushed
the
dqs/abstract-metrics
branch
from
94fd724 to
1f2b1e8
Compare
ykmr1224
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
force-pushed
the
dqs/abstract-metrics
branch
from
f9fdde6 to
9ec44c4
Compare
noCharger
reviewed
Jun 14, 2024
Comment on lines
+8
to
+15
| public enum EmrMetrics { | ||
| EMR_CANCEL_JOB_REQUEST_FAILURE_COUNT, | ||
| EMR_GET_JOB_RESULT_FAILURE_COUNT, | ||
| EMR_START_JOB_REQUEST_FAILURE_COUNT, | ||
| EMR_INTERACTIVE_QUERY_JOBS_CREATION_COUNT, | ||
| EMR_STREAMING_QUERY_JOBS_CREATION_COUNT, | ||
| EMR_BATCH_QUERY_JOBS_CREATION_COUNT; | ||
| } |
There was a problem hiding this comment.
The last three metrics relate specifically to the dispatcher, not directly to EMR APIs. It may be beneficial to group these separately from the EMR API failure metrics and consider removing the 'EMR_' prefix to avoid confusion and maintain clarity in naming conventions.
There was a problem hiding this comment.
I think those metrics are already used ones. Do you know if it is OK to change the metrics name?
There was a problem hiding this comment.
Lets only do refactoring..changing names we can handle in a different PR.
|
Look into build errors if those are related. |
vmmusings
approved these changes
Jun 21, 2024
Failures are bwc tests and looks related to version bump. |
seankao-az
approved these changes
Jun 21, 2024
rupal-bq
approved these changes
Jun 21, 2024
noCharger
approved these changes
Jun 21, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
* Abstract metrics to reduce dependency to legacy Signed-off-by: Tomoyuki Morita <[email protected]> * Add comment Signed-off-by: Tomoyuki Morita <[email protected]> * Fix style Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit ef2cef3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224
pushed a commit
that referenced
this pull request
Jun 21, 2024
* Abstract metrics to reduce dependency to legacy * Add comment * Fix style --------- (cherry picked from commit ef2cef3) Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jzonthemtn
pushed a commit
to jzonthemtn/sql
that referenced
this pull request
Aug 28, 2024
) * Abstract metrics to reduce dependency to legacy Signed-off-by: Tomoyuki Morita <[email protected]> * Add comment Signed-off-by: Tomoyuki Morita <[email protected]> * Fix style Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
n/a
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.