Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move classes from spark to async-query-core and async-query #2737

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Jun 11, 2024

Description

  • Move classes from spark to async-query-core and async-query to separate async-query-core as library.
  • There are still some dependency from async-query-core to datasources/legacy/spark, and those will be addressed in following PRs.
  • Since many classes were covered by integration tests, classes in async-query-core module are currently not covered by tests in async-query-core. Unit tests and integration tests for async-query-core will be added in following PRs. (uncovered one are excluded from coverage check right now)

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ykmr1224 ykmr1224 force-pushed the dqs/async-query-core-reorg branch from 3d2ef3b to fe1a876 Compare June 11, 2024 22:21
@ykmr1224 ykmr1224 changed the title Dqs/async query core reorg Move classes from spark to async-query-core and async-query Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.05%. Comparing base (00d5c4e) to head (fe1a876).

Current head fe1a876 differs from pull request most recent head fe5aedd

Please upload reports for the commit fe5aedd to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2737      +/-   ##
============================================
+ Coverage     95.57%   97.05%   +1.48%     
+ Complexity     5203     4578     -625     
============================================
  Files           512      405     -107     
  Lines         14652    11962    -2690     
  Branches        983      802     -181     
============================================
- Hits          14003    11610    -2393     
+ Misses          628      344     -284     
+ Partials         21        8      -13     
Flag Coverage Δ
sql-engine 97.05% <ø> (+1.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ykmr1224 ykmr1224 force-pushed the dqs/async-query-core-reorg branch from 320ef34 to f034b0d Compare June 12, 2024 15:12
ykmr1224 added 4 commits June 12, 2024 15:41
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
@ykmr1224 ykmr1224 force-pushed the dqs/async-query-core-reorg branch from f034b0d to fe5aedd Compare June 12, 2024 22:42
@ykmr1224 ykmr1224 added backport 2.x maintenance Improves code quality, but not the product labels Jun 13, 2024
@ykmr1224 ykmr1224 merged commit 084a3c8 into opensearch-project:main Jun 13, 2024
22 checks passed
@ykmr1224 ykmr1224 deleted the dqs/async-query-core-reorg branch June 13, 2024 15:41
ykmr1224 added a commit that referenced this pull request Jun 13, 2024
…query (#2737) (#2750)

* Move classes from spark to async-query-core and async-query

Signed-off-by: Tomoyuki Morita <[email protected]>

(cherry picked from commit d5c2fed)

* Fix build.gradle

Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit 61091c1)

* Adjust build.gradle

Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit ebb07ef)

* Fix copyrights

Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit 084a3c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x maintenance Improves code quality, but not the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants