Refactor data models to be generic to data storage #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
added
backport 2.x
maintenance
ykmr1224
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
seankao-az
previously approved these changes
May 21, 2024
...src/test/java/org/opensearch/sql/spark/asyncquery/AsyncQueryExecutorServiceImplSpecTest.java
Outdated
Show resolved
Hide resolved
spark/src/test/java/org/opensearch/sql/spark/asyncquery/AsyncQueryExecutorServiceImplTest.java
Outdated
Show resolved
Hide resolved
spark/src/test/java/org/opensearch/sql/spark/flint/operation/FlintIndexOpTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomoyuki Morita <[email protected]>
seankao-az
reviewed
May 22, 2024
| @@ -90,7 +88,7 @@ void testCreateAsyncQuery() { | |||
| .storeJobMetadata( | |||
| AsyncQueryJobMetadata.builder() | |||
| .queryId(QUERY_ID) | |||
| .applicationId(APPLICATION_ID) | |||
| .applicationId(EMRS_APPLICATION_ID) | |||
| .jobId(EMR_JOB_ID) | |||
| .build()); | |||
There was a problem hiding this comment.
now this can be getAsyncQueryJobMetadata()
Signed-off-by: Tomoyuki Morita <[email protected]>
rupal-bq
approved these changes
May 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 22, 2024
* Refactor data models to be generic to data storage Signed-off-by: Tomoyuki Morita <[email protected]> * Address review comments Signed-off-by: Tomoyuki Morita <[email protected]> * Reduce redundancy Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit 3a28d2a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224
pushed a commit
that referenced
this pull request
May 23, 2024
* Refactor data models to be generic to data storage * Address review comments * Reduce redundancy --------- (cherry picked from commit 3a28d2a) Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
n/a
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.