Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Spark datasource #2638

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Delete Spark datasource #2638

merged 4 commits into from
Apr 30, 2024

Conversation

ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Apr 26, 2024 •
edited
Loading

Description

Delete Spark datasource related classes since it is no longer used.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ykmr1224
Delete Spark datasource
0287f62 
Signed-off-by: Tomoyuki Morita <[email protected]>
@ykmr1224 ykmr1224 marked this pull request as ready for review April 26, 2024 17:07
@vmmusings
Copy link
Member

vmmusings commented Apr 26, 2024 •
edited
Loading

High level comments.

  • can we also rename the module to async-query-api probably..or whatever is best.
  • probably need to update documentation if there is anything for spark datasource.

@ykmr1224
Copy link
Collaborator Author

  • can we also rename the module to async-query-api probably..or whatever is best.
    I am thinking to rename the module once all the refactoring is done together with the module split.
  • probably need to update documentation if there is anything for spark datasource.
    I see only see spark: Spark storage engine in DEVELOPER_GUIDE.rst. Let me fix it together with package name change and split.

@vmmusings
Copy link
Member

@ykmr1224 can you look into build errors in CI.

@vmmusings
Copy link
Member

https://github.com/opensearch-project/sql/blob/main/docs/user/ppl/admin/connectors/spark_connector.rst
This rst file is not required anymore.

ykmr1224 added 2 commits April 26, 2024 21:58
@ykmr1224
Fix build error
83286c4 
Signed-off-by: Tomoyuki Morita <[email protected]>
@ykmr1224
Delete spark_connector.rst
9d52dfd 
Signed-off-by: Tomoyuki Morita <[email protected]>
@ykmr1224
Copy link
Collaborator Author

Fixed the coverage issue, and deleted spark_connector.rst

@ykmr1224
Add missing test
d1c975d 
Signed-off-by: Tomoyuki Morita <[email protected]>
@ykmr1224
Copy link
Collaborator Author

Fixed another coverage issue.

@vmmusings vmmusings added maintenance Improves code quality, but not the product backport 2.x labels Apr 30, 2024
@vmmusings vmmusings merged commit de7b367 into opensearch-project:main Apr 30, 2024
22 of 28 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 30, 2024
@github-actions
Delete Spark datasource (#2638)
ed140e9 
* Delete Spark datasource

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix build error

Signed-off-by: Tomoyuki Morita <[email protected]>

* Delete spark_connector.rst

Signed-off-by: Tomoyuki Morita <[email protected]>

* Add missing test

Signed-off-by: Tomoyuki Morita <[email protected]>

---------

Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit de7b367)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 30, 2024
Closed
@ykmr1224 ykmr1224 mentioned this pull request May 10, 2024
Merged
6 tasks
ykmr1224 added a commit that referenced this pull request May 13, 2024
@ykmr1224 @github-actions
[Backport 2.x] Delete Spark datasource (#2638) (#2667)
8a9d38c 
* Delete Spark datasource (#2638)

* Delete Spark datasource

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix build error

Signed-off-by: Tomoyuki Morita <[email protected]>

* Delete spark_connector.rst

Signed-off-by: Tomoyuki Morita <[email protected]>

* Add missing test

Signed-off-by: Tomoyuki Morita <[email protected]>

---------

Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit de7b367)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix test failure in DefaultSparkSqlFunctionResponseHandleTest

Signed-off-by: Tomoyuki Morita <[email protected]>

* Reformat

Signed-off-by: Tomoyuki Morita <[email protected]>

---------

Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224 added a commit to ykmr1224/sql that referenced this pull request May 23, 2024
@ykmr1224
Revert "Delete Spark datasource (opensearch-project#2638)"
523ca39 
This reverts commit de7b367.
ykmr1224 added a commit to ykmr1224/sql that referenced this pull request May 23, 2024
@ykmr1224
Revert "Delete Spark datasource (opensearch-project#2638)"
19301a5 
This reverts commit de7b367.

Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224 added a commit that referenced this pull request Jun 6, 2024
@ykmr1224
Revert "Delete Spark datasource (#2638)" (#2692)
60c4d50 
This reverts commit de7b367.

Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224 added a commit to ykmr1224/sql that referenced this pull request Jun 6, 2024
@ykmr1224
Revert "Delete Spark datasource (opensearch-project#2638)" (opensearc…
38bf51d 
…h-project#2692)

This reverts commit de7b367.

Signed-off-by: Tomoyuki Morita <[email protected]>

(cherry picked from commit 60c4d50)
@ykmr1224 ykmr1224 mentioned this pull request Jun 6, 2024
Merged
6 tasks
ykmr1224 added a commit to ykmr1224/sql that referenced this pull request Jun 6, 2024
@ykmr1224
Revert "Delete Spark datasource (opensearch-project#2638)" (opensearc…
b69bb2b 
…h-project#2692)

This reverts commit de7b367.

Signed-off-by: Tomoyuki Morita <[email protected]>

(cherry picked from commit 60c4d50)
ykmr1224 added a commit that referenced this pull request Jun 6, 2024
@ykmr1224
Revert "Delete Spark datasource (#2638)" (#2692) (#2722)
bcfafc1 
This reverts commit de7b367.

Signed-off-by: Tomoyuki Morita <[email protected]>

(cherry picked from commit 60c4d50)
jzonthemtn pushed a commit to jzonthemtn/sql that referenced this pull request Aug 28, 2024
@ykmr1224 @jzonthemtn
Revert "Delete Spark datasource (opensearch-project#2638)" (opensearc…
0c5fe4f 
…h-project#2692)

This reverts commit de7b367.

Signed-off-by: Tomoyuki Morita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seankao-az seankao-az seankao-az approved these changes

@vmmusings vmmusings vmmusings approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

Assignees

@ykmr1224 ykmr1224

Labels
backport 2.x maintenance Improves code quality, but not the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ykmr1224 @vmmusings @seankao-az