Refactor SparkQueryDispatcher #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
vmmusings
reviewed
Apr 26, 2024
spark/src/main/java/org/opensearch/sql/spark/dispatcher/SparkQueryDispatcher.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomoyuki Morita <[email protected]>
|
Removed EMRServerlessClientFactory from SparkQueryDispatcher, and fixed build error due to spotless check |
ykmr1224
force-pushed
the
refactor-spark
branch
2 times, most recently
from
986cbc7 to
bbed24a
Compare
Signed-off-by: Tomoyuki Morita <[email protected]>
vmmusings
added
maintenance
seankao-az
approved these changes
Apr 30, 2024
vmmusings
approved these changes
Apr 30, 2024
vmmusings
approved these changes
Apr 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Refactor SparkQueryDispatcher Signed-off-by: Tomoyuki Morita <[email protected]> * Remove EMRServerlessClientFactory from SparkQueryDispatcher Signed-off-by: Tomoyuki Morita <[email protected]> * Fix unit test failures in SparkQueryDispatcherTest Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit d32cf94) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224
pushed a commit
to ykmr1224/sql
that referenced
this pull request
May 13, 2024
* Refactor SparkQueryDispatcher Signed-off-by: Tomoyuki Morita <[email protected]> * Remove EMRServerlessClientFactory from SparkQueryDispatcher Signed-off-by: Tomoyuki Morita <[email protected]> * Fix unit test failures in SparkQueryDispatcherTest Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit d32cf94) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced May 13, 2024
ykmr1224
added a commit
that referenced
this pull request
May 14, 2024
* Refactor SparkQueryDispatcher (#2636) * Refactor SparkQueryDispatcher Signed-off-by: Tomoyuki Morita <[email protected]> * Remove EMRServerlessClientFactory from SparkQueryDispatcher Signed-off-by: Tomoyuki Morita <[email protected]> * Fix unit test failures in SparkQueryDispatcherTest Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit d32cf94) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix conflicted test case Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor SparkQueryDispatcher to reduce the direct dependency (pure refactoring).
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.