Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw OpensearchSecurityException incase of datasource authorization … #2626

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

vmmusings
Copy link
Member

@vmmusings vmmusings commented Apr 18, 2024

Description

Throw OpensearchSecurityException in case of datasource authorization error. Today we are throwing SecurityException from java and it is resulting in 500 error. With this change we are throwing OpensearchSecurityException with 403 as error code.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmmusings vmmusings self-assigned this Apr 18, 2024
@vmmusings vmmusings added bug Something isn't working backport 2.x labels Apr 18, 2024
@vmmusings vmmusings merged commit 5464bfc into opensearch-project:main Apr 22, 2024
25 of 28 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 22, 2024
…error (#2626)

Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit 5464bfc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vmmusings pushed a commit that referenced this pull request Apr 22, 2024
…error (#2626) (#2634)

(cherry picked from commit 5464bfc)

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants