Make Statemodels free of XContent #2619
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmmusings
changed the title
vmmusings
force-pushed
the
refactor-state-models
branch
4 times, most recently
from
012be35 to
ff702ed
Compare
Signed-off-by: Vamsi Manohar <[email protected]>
vmmusings
force-pushed
the
refactor-state-models
branch
from
ff702ed to
fd75fcd
Compare
vmmusings
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
rupal-bq
reviewed
Apr 17, 2024
| @@ -0,0 +1,5 @@ | |||
| package org.opensearch.sql.spark.execution.statestore; | |||
There was a problem hiding this comment.
missing copyright. also in interface FromXContent and StateCopyBuilder.
rupal-bq
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Meta Issue: #2623
As part of moving all the non-opensearch classes to a separate async-query-core module. We are removing the dependency of opensearch on state models by moving all the XContent serialization and deserialization functionality to separate classes and made state models simple POJOs.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.