Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Flint SQL grammar #2558

Closed

Conversation

dai-chen
Copy link
Collaborator

Description

Added latest Flint SQL grammar changes as below.

Issues Resolved

  1. ALTER statement: Add grammar files for alter index opensearch-spark#279
  2. BLOOM_FILTER skip type: Add BloomFilter skipping index SQL support opensearch-spark#283

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chen Dai <[email protected]>
@dai-chen dai-chen added enhancement New feature or request backport 2.x labels Mar 18, 2024
@dai-chen dai-chen self-assigned this Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.47%. Comparing base (a84c3ef) to head (7b165de).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2558   +/-   ##
=========================================
  Coverage     95.47%   95.47%           
  Complexity     5046     5046           
=========================================
  Files           486      486           
  Lines         14087    14087           
  Branches        943      943           
=========================================
  Hits          13450    13450           
  Misses          614      614           
  Partials         23       23           
Flag Coverage Δ
sql-engine 95.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dai-chen
Copy link
Collaborator Author

Confirmed with @vamsi-amazon that #2554 will cover all latest Flint SQL grammar changes, including:

  1. ALTER statement: Add grammar files for alter index opensearch-spark#279
  2. BLOOM_FILTER skip type: Add BloomFilter skipping index SQL support opensearch-spark#283
  3. ANALYZE statement: Implement analyze skipping index statement opensearch-spark#284

Closing this PR as not needed any more.

@dai-chen dai-chen closed this Mar 18, 2024
@dai-chen dai-chen deleted the add-new-flint-grammar branch March 18, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant