Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Restrict the scope of cancel API #2556

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a84c3ef from #2548.

* Restric cancel the scope of cancel API

Signed-off-by: Peng Huo <[email protected]>

* Fix UT, batch query only been used for REFRESH

Signed-off-by: Peng Huo <[email protected]>

* Update style

Signed-off-by: Peng Huo <[email protected]>

* support cancel refresh query

Signed-off-by: Peng Huo <[email protected]>

* fix UT

Signed-off-by: Peng Huo <[email protected]>

* refactor code

Signed-off-by: Peng Huo <[email protected]>

* update doc

Signed-off-by: Peng Huo <[email protected]>

* refactor code

Signed-off-by: Peng Huo <[email protected]>

---------

Signed-off-by: Peng Huo <[email protected]>
(cherry picked from commit a84c3ef)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 98.27586% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.53%. Comparing base (89c8234) to head (ace361f).

Files Patch % Lines
.../spark/asyncquery/model/AsyncQueryJobMetadata.java 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #2556      +/-   ##
============================================
+ Coverage     95.49%   95.53%   +0.03%     
- Complexity     5068     5083      +15     
============================================
  Files           485      487       +2     
  Lines         14199    14252      +53     
  Branches        943      946       +3     
============================================
+ Hits          13559    13615      +56     
+ Misses          619      614       -5     
- Partials         21       23       +2     
Flag Coverage Δ
sql-engine 95.53% <98.27%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penghuo penghuo merged commit 1f11fbe into 2.x Mar 14, 2024
38 of 39 checks passed
@github-actions github-actions bot deleted the backport/backport-2548-to-2.x branch March 14, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants