-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting plugins.query.executionengine.async_query.enabled #2510
Conversation
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2510 +/- ##
=========================================
Coverage 95.41% 95.41%
- Complexity 5026 5027 +1
=========================================
Files 483 483
Lines 14005 14016 +11
Branches 944 944
=========================================
+ Hits 13363 13374 +11
Misses 621 621
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@penghuo can we disable async_query by |
no.
|
@@ -46,6 +52,16 @@ protected void doExecute( | |||
CreateAsyncQueryActionRequest request, | |||
ActionListener<CreateAsyncQueryActionResponse> listener) { | |||
try { | |||
if (!(Boolean) pluginSettings.getSettingValue(Settings.Key.ASYNC_QUERY_ENABLED)) { | |||
listener.onFailure( | |||
new IllegalAccessException( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IllegalAccessException
seems a Java reflection related exception?
* Add setting plugins.query.executionengine.async_query.enabled Signed-off-by: Peng Huo <[email protected]> * fix format Signed-off-by: Peng Huo <[email protected]> --------- Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit cddffc6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#2512) * Add setting plugins.query.executionengine.async_query.enabled * fix format --------- (cherry picked from commit cddffc6) Signed-off-by: Peng Huo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Issues Resolved
#2507
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.