[DOC] Configure the Spark metrics properties while creating a s3 Glue Connector #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noCharger
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
noCharger
changed the title
…ctor Signed-off-by: Louis Chu <[email protected]>
vmmusings
reviewed
Feb 6, 2024
vmmusings
reviewed
Feb 6, 2024
vmmusings
reviewed
Feb 6, 2024
Signed-off-by: Louis Chu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2504 +/- ##
=========================================
Coverage 95.41% 95.41%
Complexity 5026 5026
=========================================
Files 483 483
Lines 14005 14005
Branches 944 944
=========================================
Hits 13363 13363
Misses 621 621
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Louis Chu <[email protected]>
dai-chen
approved these changes
Feb 6, 2024
vmmusings
approved these changes
Feb 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
… Connector (#2504) * Configure the Spark metrics properties while creating a s3 Glue Connector Signed-off-by: Louis Chu <[email protected]> * Address comments from Vamsi Signed-off-by: Louis Chu <[email protected]> * Refactor the whole config section Signed-off-by: Louis Chu <[email protected]> --------- Signed-off-by: Louis Chu <[email protected]> (cherry picked from commit 4f54d46) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vmmusings
pushed a commit
that referenced
this pull request
Feb 6, 2024
… Connector (#2504) (#2508) * Configure the Spark metrics properties while creating a s3 Glue Connector * Address comments from Vamsi * Refactor the whole config section --------- (cherry picked from commit 4f54d46) Signed-off-by: Louis Chu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/noCharger/sql/blob/patch-1/docs/user/interfaces/asyncqueryinterface.rst#required-spark-execution-engine-config-for-async-query-apis
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.