Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes #2491

Closed
wants to merge 1 commit into from
Closed

Conversation

vmmusings
Copy link
Member

@vmmusings vmmusings commented Jan 31, 2024

Description

  • doctest module doesn't contain any Java files. So removing SpotlessJava which is unnecessarily causing issues with build.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vamsi Manohar <[email protected]>
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f30aea) 95.41% compared to head (ac394c1) 95.41%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2491   +/-   ##
=========================================
  Coverage     95.41%   95.41%           
  Complexity     5000     5000           
=========================================
  Files           479      479           
  Lines         13950    13950           
  Branches        937      937           
=========================================
  Hits          13310    13310           
  Misses          618      618           
  Partials         22       22           
Flag Coverage Δ
sql-engine 95.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vmmusings vmmusings closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant