-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster name in spark submit params #2467
Conversation
Signed-off-by: Louis Chu <[email protected]>
5bd122f
to
e8ca07a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
=========================================
Coverage 95.40% 95.41%
Complexity 5000 5000
=========================================
Files 479 479
Lines 13939 13950 +11
Branches 937 937
=========================================
+ Hits 13299 13310 +11
Misses 618 618
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
https://github.com/opensearch-project/sql/actions/runs/7402675720/job/20141020203?pr=2467 CI failed on an unrelated code path: DateTimeFunctionTest > testWeekOfYearWithTimeType() FAILED Create a issue to track the fix #2468 |
spark/src/main/java/org/opensearch/sql/spark/asyncquery/model/SparkSubmitParameters.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Louis Chu <[email protected]>
65397e4
to
c9bb54d
Compare
Can we comment those and verify if the rest of the tests are working fine. Just to be sure the new code is not causing any regression. |
@vamsi-amazon I don't think these failed UTs are related to the new code. It has causing CI failed for a while (for example it shown in previous PR https://github.com/opensearch-project/sql/actions/runs/7383460047/job/20084703703?pr=2464) Also all CI tasks in spark component are succeeded.
|
Thanks team for the review, can someone merge this PR? |
* Add cluster name in spark submit params Signed-off-by: Louis Chu <[email protected]> * Include cluster name to spark env Signed-off-by: Louis Chu <[email protected]> --------- Signed-off-by: Louis Chu <[email protected]> (cherry picked from commit efb159a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add cluster name in spark submit params Signed-off-by: Louis Chu <[email protected]> * Include cluster name to spark env Signed-off-by: Louis Chu <[email protected]> --------- Signed-off-by: Louis Chu <[email protected]> (cherry picked from commit efb159a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add cluster name in spark submit params * Include cluster name to spark env --------- (cherry picked from commit efb159a) Signed-off-by: Louis Chu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Add cluster name in spark submit params
Issues Resolved
#2465
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.