Create Result Index immediately after datasource creation. #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamsimanohar
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2414 +/- ##
=========================================
Coverage 95.54% 95.55%
- Complexity 4985 4988 +3
=========================================
Files 478 478
Lines 13883 13910 +27
Branches 931 932 +1
=========================================
+ Hits 13265 13292 +27
Misses 598 598
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
penghuo
reviewed
Nov 3, 2023
| throw new RuntimeException("Index creation is not acknowledged."); | ||
| } | ||
| } catch (Throwable e) { | ||
| LOG.error("Datasource Query Result Index Creation failed due to :{}", e.getMessage()); |
There was a problem hiding this comment.
if result index created failed, datasource creation should failed?
vamsimanohar
force-pushed
the
main
branch
2 times, most recently
from
67f4b15 to
aad2032
Compare
Signed-off-by: Vamsi Manohar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#2268
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.