Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x]Add missing tags and MV support (#2336) #2347

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

vmmusings
Copy link
Member

Signed-off-by: Vamsi Manohar [email protected]
(cherry picked from commit 877c9c3)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit 877c9c3)
@vmmusings vmmusings changed the title Add missing tags and MV support (#2336) [Backport 2.x]Add missing tags and MV support (#2336) Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2347 (b45bc17) into 2.x (f3fdead) will decrease coverage by 0.04%.
The diff coverage is 93.25%.

@@             Coverage Diff              @@
##                2.x    #2347      +/-   ##
============================================
- Coverage     96.53%   96.50%   -0.04%     
- Complexity     4928     4935       +7     
============================================
  Files           464      465       +1     
  Lines         13532    13585      +53     
  Branches        904      906       +2     
============================================
+ Hits          13063    13110      +47     
- Misses          452      456       +4     
- Partials         17       19       +2     
Flag Coverage Δ
sql-engine 96.50% <93.25%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...earch/sql/spark/data/constants/SparkConstants.java 0.00% <ø> (ø)
...rch/sql/spark/dispatcher/SparkQueryDispatcher.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/spark/utils/SQLQueryUtils.java 100.00% <100.00%> (ø)
...earch/sql/spark/dispatcher/model/IndexDetails.java 95.34% <95.23%> (-4.66%) ⬇️
...opensearch/sql/spark/dispatcher/model/JobType.java 66.66% <66.66%> (ø)

@penghuo penghuo merged commit 66a20b7 into 2.x Oct 24, 2023
30 of 34 checks passed
@github-actions github-actions bot deleted the backport/backport-fail-2336-to-2.x branch October 24, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants