Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide auth.type and auth.role_arn paramters in GET Datasource API response. #2276

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Provide auth.type and auth.role_arn paramters in GET Datasource API response. #2276

merged 1 commit into from
Oct 11, 2023

Conversation

vmmusings
Copy link
Member

Description

  • Allow all auth parameters except for auth.username, auth.password, auth.access_key and auth.secret_key in datasource GET API results.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vmmusings vmmusings self-assigned this Oct 10, 2023
@vmmusings vmmusings added bug Something isn't working Flint backport 2.x labels Oct 10, 2023
@vmmusings vmmusings changed the title Provide auth.type and auth.role_arn paramters to end user Provide auth.type and auth.role_arn paramters in GET Datasource API response. Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #2276 (947abf2) into main (b654e43) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #2276   +/-   ##
=========================================
  Coverage     96.60%   96.61%           
- Complexity     4738     4739    +1     
=========================================
  Files           442      442           
  Lines         12741    12747    +6     
  Branches        876      876           
=========================================
+ Hits          12309    12315    +6     
  Misses          424      424           
  Partials          8        8
Flag Coverage Δ
sql-engine 96.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...sql/datasources/service/DataSourceServiceImpl.java 100.00% <100.00%> (ø)

derek-ho
derek-ho approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmmusings vmmusings merged commit 9f17c4e into opensearch-project:main Oct 11, 2023
19 of 21 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 11, 2023
@github-actions
Provide auth.type and auth.role_arn paramters to end user (#2276)
04b9a57 
Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit 9f17c4e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 11, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 11, 2023
@github-actions
Provide auth.type and auth.role_arn paramters to end user (#2276)
45cdb7a 
Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit 9f17c4e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 11, 2023
Merged
vmmusings pushed a commit that referenced this pull request Oct 11, 2023
@opensearch-trigger-bot @github-actions
Provide auth.type and auth.role_arn paramters to end user (#2276) (#2281
ab02486 
)

(cherry picked from commit 9f17c4e)

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vmmusings pushed a commit that referenced this pull request Oct 11, 2023
@opensearch-trigger-bot @github-actions
Provide auth.type and auth.role_arn paramters to end user (#2276) (#2283
34ee39d 
)

(cherry picked from commit 9f17c4e)

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derek-ho derek-ho derek-ho approved these changes

@penghuo penghuo penghuo approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

Assignees

@vmmusings vmmusings

Labels
backport 2.x backport 2.11 bug Something isn't working Flint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmmusings @penghuo @derek-ho