[Backport 2.x] Read extra Spark submit parameters from cluster settings #2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add default setting for Spark execution engine Signed-off-by: Chen Dai <[email protected]> * Pass extra parameters to Spark dispatcher Signed-off-by: Chen Dai <[email protected]> * Wrap read default setting file with previlege action Signed-off-by: Chen Dai <[email protected]> * Fix spotless format Signed-off-by: Chen Dai <[email protected]> * Use input stream to read default config file Signed-off-by: Chen Dai <[email protected]> * Add UT for dispatcher Signed-off-by: Chen Dai <[email protected]> * Add more UT Signed-off-by: Chen Dai <[email protected]> * Remove default config setting Signed-off-by: Chen Dai <[email protected]> * Fix spotless check in spark module Signed-off-by: Chen Dai <[email protected]> * Refactor test code Signed-off-by: Chen Dai <[email protected]> * Add more UT on config class Signed-off-by: Chen Dai <[email protected]> --------- Signed-off-by: Chen Dai <[email protected]> (cherry picked from commit 492982c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
dai-chen
approved these changes
Oct 5, 2023
vmmusings
approved these changes
Oct 5, 2023
penghuo
approved these changes
Oct 5, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #2235 +/- ##
============================================
+ Coverage 96.39% 96.40% +0.01%
Complexity 4762 4762
============================================
Files 440 440
Lines 12849 12858 +9
Branches 874 874
============================================
+ Hits 12386 12396 +10
Misses 454 454
+ Partials 9 8 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 492982c from #2219.