Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Flint Auth #2190

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

vmmusings
Copy link
Member

@vmmusings vmmusings commented Oct 3, 2023

Description

  • false is replaced with noauth for glue.indexstore.opensearch.auth property.
  • Fixed few more bugs in indexstore parameters.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

YANG-DB
YANG-DB previously approved these changes Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #2190 (bd1f9d0) into main (5ce1bab) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2190      +/-   ##
============================================
+ Coverage     96.55%   96.57%   +0.01%     
- Complexity     4715     4717       +2     
============================================
  Files           436      436              
  Lines         12532    12543      +11     
  Branches        856      857       +1     
============================================
+ Hits          12100    12113      +13     
  Misses          422      422              
+ Partials         10        8       -2     
Flag Coverage Δ
sql-engine 96.57% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...earch/sql/datasources/auth/AuthenticationType.java 100.00% <100.00%> (ø)
...ch/sql/datasources/glue/GlueDataSourceFactory.java 100.00% <100.00%> (ø)
...s/storage/OpenSearchDataSourceMetadataStorage.java 100.00% <100.00%> (+1.24%) ⬆️
...l/prometheus/storage/PrometheusStorageFactory.java 100.00% <ø> (ø)
.../asyncquery/model/S3GlueSparkSubmitParameters.java 100.00% <ø> (ø)
...earch/sql/spark/data/constants/SparkConstants.java 0.00% <ø> (ø)
...rch/sql/spark/dispatcher/SparkQueryDispatcher.java 100.00% <100.00%> (ø)

@penghuo penghuo added the v2.11.0 Issues targeting release v2.11.0 label Oct 3, 2023
@vmmusings vmmusings force-pushed the refactor-flint-auth branch from 82a348f to 3cba4ed Compare October 3, 2023 21:30
penghuo
penghuo previously approved these changes Oct 3, 2023
@vmmusings vmmusings force-pushed the refactor-flint-auth branch from 3cba4ed to 253aa5c Compare October 3, 2023 21:46
Signed-off-by: Vamsi Manohar <[email protected]>
@vmmusings vmmusings merged commit fca59a1 into opensearch-project:main Oct 3, 2023
23 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2023
Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit fca59a1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo pushed a commit that referenced this pull request Oct 3, 2023
(cherry picked from commit fca59a1)

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Flint v2.11.0 Issues targeting release v2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants