Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging Async Query APIs feature branch into main. #2159

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Conversation

vmmusings
Copy link
Member

Description

  • Add new APIs for async query support for s3 and cwl datasources.
  • Add S3Glue Connector API.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vamsi Manohar <[email protected]>
* Create Job API

Signed-off-by: Vamsi Manohar <[email protected]>

* Refactor to Async Query API

Signed-off-by: Vamsi Manohar <[email protected]>

---------

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: Vamsi Manohar <[email protected]>
@vmmusings vmmusings added enhancement New feature or request backport 2.x labels Sep 26, 2023
@vmmusings vmmusings self-assigned this Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #2159 (e3c4ee6) into main (7bad8f9) will decrease coverage by 0.72%.
The diff coverage is 82.70%.

@@             Coverage Diff              @@
##               main    #2159      +/-   ##
============================================
- Coverage     97.28%   96.56%   -0.72%     
- Complexity     4622     4717      +95     
============================================
  Files           410      436      +26     
  Lines         11942    12535     +593     
  Branches        824      858      +34     
============================================
+ Hits          11618    12105     +487     
- Misses          317      420     +103     
- Partials          7       10       +3     
Flag Coverage Δ
sql-engine 96.56% <82.70%> (-0.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ch/sql/datasources/glue/GlueDataSourceFactory.java 100.00% <100.00%> (ø)
...ql/datasources/rest/RestDataSourceQueryAction.java 0.00% <ø> (ø)
...sql/datasources/service/DataSourceServiceImpl.java 100.00% <100.00%> (ø)
...l/datasources/utils/DatasourceValidationUtils.java 100.00% <100.00%> (ø)
...rch/sql/opensearch/setting/OpenSearchSettings.java 100.00% <100.00%> (ø)
...park/asyncquery/AsyncQueryExecutorServiceImpl.java 100.00% <100.00%> (ø)
...OpensearchAsyncQueryJobMetadataStorageService.java 100.00% <100.00%> (ø)
...cquery/exceptions/AsyncQueryNotFoundException.java 100.00% <100.00%> (ø)
...h/sql/spark/asyncquery/model/AsyncQueryResult.java 100.00% <100.00%> (ø)
.../asyncquery/model/S3GlueSparkSubmitParameters.java 100.00% <100.00%> (ø)
... and 24 more

@vmmusings vmmusings added Flint v2.11.0 Issues targeting release v2.11.0 labels Sep 27, 2023
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is CI failure only BWC right?

@vmmusings vmmusings merged commit ae10857 into main Sep 27, 2023
22 of 28 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 27, 2023
* Glue datasource support (#2055)

Signed-off-by: Vamsi Manohar <[email protected]>

* Initial commit of new job APIs (#2050)

Signed-off-by: Vamsi Manohar <[email protected]>

* Create Job API (#2070)

* Create Job API

Signed-off-by: Vamsi Manohar <[email protected]>

* Refactor to Async Query API

Signed-off-by: Vamsi Manohar <[email protected]>

---------

Signed-off-by: Vamsi Manohar <[email protected]>

* Cancel Job API (#2126)

Signed-off-by: Vamsi Manohar <[email protected]>

* Add tags to the emr jobs based on the query types (#2150)

Signed-off-by: Vamsi Manohar <[email protected]>

---------

Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit ae10857)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vmmusings pushed a commit that referenced this pull request Sep 27, 2023
* Glue datasource support (#2055)



* Initial commit of new job APIs (#2050)



* Create Job API (#2070)

* Create Job API



* Refactor to Async Query API



---------



* Cancel Job API (#2126)



* Add tags to the emr jobs based on the query types (#2150)



---------


(cherry picked from commit ae10857)

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request Flint v2.11.0 Issues targeting release v2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants