Unify internal OpenSearch exceptions with returned status code (#3068)

Signed-off-by: Simeon Widdis <[email protected]>
opensearch-project · Oct 12, 2024 · 4c44f56 · 4c44f56
1 parent cf1564b
commit 4c44f56
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/integ-test/src/test/java/org/opensearch/sql/legacy/CursorIT.java b/integ-test/src/test/java/org/opensearch/sql/legacy/CursorIT.java
@@ -393,7 +393,7 @@ public void invalidCursorIdNotDecodable() throws IOException {
 
     JSONObject resp = new JSONObject(TestUtils.getResponseBody(response));
     assertThat(resp.getInt("status"), equalTo(400));
-    assertThat(resp.query("/error/type"), equalTo("illegal_argument_exception"));
+    assertThat(resp.query("/error/type"), equalTo("IllegalArgumentException"));
   }
 
   /**

diff --git a/legacy/src/main/java/org/opensearch/sql/legacy/executor/format/OpenSearchErrorMessage.java b/legacy/src/main/java/org/opensearch/sql/legacy/executor/format/OpenSearchErrorMessage.java
@@ -12,8 +12,8 @@
 
 public class OpenSearchErrorMessage extends ErrorMessage<OpenSearchException> {
 
-  OpenSearchErrorMessage(OpenSearchException exception, int status) {
-    super(exception, status);
+  OpenSearchErrorMessage(OpenSearchException exception, int defaultStatus) {
+    super(exception, exception.status() != null ? exception.status().getStatus() : defaultStatus);
   }
 
   @Override

diff --git a/...ch/src/main/java/org/opensearch/sql/opensearch/response/error/OpenSearchErrorMessage.java b/...ch/src/main/java/org/opensearch/sql/opensearch/response/error/OpenSearchErrorMessage.java
@@ -13,8 +13,8 @@
 /** OpenSearch Error Message. */
 public class OpenSearchErrorMessage extends ErrorMessage {
 
-  OpenSearchErrorMessage(OpenSearchException exception, int status) {
-    super(exception, status);
+  OpenSearchErrorMessage(OpenSearchException exception, int defaultStatus) {
+    super(exception, exception.status() != null ? exception.status().getStatus() : defaultStatus);
   }
 
   @Override