Remove unused methods

Signed-off-by: Rupal Mahajan <[email protected]>
opensearch-project · Jun 16, 2024 · 0857a6b · 0857a6b
1 parent bee4863
commit 0857a6b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 23 deletions.
diff --git a/legacy/src/main/java/org/opensearch/sql/legacy/executor/join/ElasticJoinExecutor.java b/legacy/src/main/java/org/opensearch/sql/legacy/executor/join/ElasticJoinExecutor.java
@@ -55,7 +55,7 @@ public abstract class ElasticJoinExecutor implements ElasticHitsExecutor {
   protected final int MAX_RESULTS_ON_ONE_FETCH = 10000;
   private Set<String> aliasesOnReturn;
   private boolean allFieldsReturn;
-  private PointInTimeHandler pit;
+  protected PointInTimeHandler pit;
 
   protected ElasticJoinExecutor(JoinRequestBuilder requestBuilder) {
     metaResults = new MetaSearchResult();
@@ -302,19 +302,11 @@ public SearchResponse getResponseWithHits(
     return responseWithHits;
   }
 
-  public void createPointInTime(
-      org.opensearch.client.Client client, JoinRequestBuilder requestBuilder) {
+  public void createPointInTimeHandler(Client client, JoinRequestBuilder requestBuilder) {
     String[] indices =
         org.opensearch.common.util.ArrayUtils.concat(
             requestBuilder.getFirstTable().getOriginalSelect().getIndexArr(),
             requestBuilder.getSecondTable().getOriginalSelect().getIndexArr());
     pit = new PointInTimeHandler(client, indices);
-    pit.create();
-  }
-
-  public void deletePointInTime() {
-    if (pit != null) {
-      pit.delete();
-    }
   }
 }
diff --git a/legacy/src/main/java/org/opensearch/sql/legacy/executor/join/HashJoinElasticExecutor.java b/legacy/src/main/java/org/opensearch/sql/legacy/executor/join/HashJoinElasticExecutor.java
@@ -53,7 +53,8 @@ public HashJoinElasticExecutor(Client client, HashJoinElasticRequestBuilder requ
   }
 
   public List<SearchHit> innerRun() throws IOException, SqlParseException {
-    createPointInTime(client, requestBuilder);
+    createPointInTimeHandler(client, requestBuilder);
+    pit.create();
 
     Map<String, Map<String, List<Object>>> optimizationTermsFilterStructure =
         initOptimizationStructure();
@@ -96,7 +97,7 @@ public int compare(SearchHit o1, SearchHit o2) {
             }
           });
     }
-    deletePointInTime();
+    pit.delete();
     return combinedResult;
   }
 

diff --git a/legacy/src/main/java/org/opensearch/sql/legacy/executor/join/NestedLoopsElasticExecutor.java b/legacy/src/main/java/org/opensearch/sql/legacy/executor/join/NestedLoopsElasticExecutor.java
@@ -48,7 +48,8 @@ public NestedLoopsElasticExecutor(Client client, NestedLoopsElasticRequestBuilde
 
   @Override
   protected List<SearchHit> innerRun() throws SqlParseException {
-    createPointInTime(client, nestedLoopsRequest);
+    createPointInTimeHandler(client, nestedLoopsRequest);
+    pit.create();
     List<SearchHit> combinedResults = new ArrayList<>();
     int totalLimit = nestedLoopsRequest.getTotalLimit();
     int multiSearchMaxSize = nestedLoopsRequest.getMultiSearchMaxSize();
@@ -129,7 +130,7 @@ protected List<SearchHit> innerRun() throws SqlParseException {
         }
       }
     }
-    deletePointInTime();
+    pit.delete();
     return combinedResults;
   }
 

diff --git a/legacy/src/main/java/org/opensearch/sql/legacy/query/join/TableInJoinRequestBuilder.java b/legacy/src/main/java/org/opensearch/sql/legacy/query/join/TableInJoinRequestBuilder.java
@@ -17,7 +17,6 @@ public class TableInJoinRequestBuilder {
   private List<Field> returnedFields;
   private Select originalSelect;
   private Integer hintLimit;
-  private String pitId;
 
   public TableInJoinRequestBuilder() {}
 
@@ -60,12 +59,4 @@ public Integer getHintLimit() {
   public void setHintLimit(Integer hintLimit) {
     this.hintLimit = hintLimit;
   }
-
-  public String getPitId() {
-    return pitId;
-  }
-
-  public void setPitId(String pitId) {
-    this.pitId = pitId;
-  }
 }