Adding Alerting Comments and Correlation Alerts system indices

[toepkerd]

Description

Adding Alerting Comments and Correlation Alerts system indices to SecuritySettingsConfigurer.

To be backported to 2.15 and 2.16.

Separate PRs within our respective Alerting and Security Analytics plugins are being raised to update getSystemIndexDescriptors(), which will cover the >= 2.17 cases of allowing these indices to be registered in Security as system indices.

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

• New functionality includes testing
• New functionality has been documented
• New Roles/Permissions have a corresponding security dashboards plugin PR
• API changes companion pull request created
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[cwperks]

@toepkerd This list has been made redundant in 2.17. The security plugin can now determine if a request matches system indices directly from a registry of system indices from the core: #4535

Plugins can register system index patterns through the SystemIndexPlugin.getSystemIndexDescriptors extension point

Example from this repo: https://github.com/opensearch-project/security/blob/main/src/main/java/org/opensearch/security/OpenSearchSecurityPlugin.java#L2090-L2098

[toepkerd]

Closing as the list is redundant with a 2.17 change

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.51%. Comparing base (014c8de) to head (dace996).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4727      +/-   ##
==========================================
- Coverage   65.56%   65.51%   -0.05%     
==========================================
  Files         319      319              
  Lines       22448    22448              
  Branches     3602     3602              
==========================================
- Hits        14718    14707      -11     
- Misses       5921     5931      +10     
- Partials     1809     1810       +1     

Files with missing lines	Coverage Δ
...y/tools/democonfig/SecuritySettingsConfigurer.java	76.71% <ø> (ø)

... and 4 files with indirect coverage changes