Use evaluateSslExceptionHandler() when constructing OpenSearchSecureSettingsFactory

[reta]

Description

While working on #4119, a minor regression related to configuring the right sslExceptionHandler sneaked in, fixing it now.

Issues Resolved

Part of #4718

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

• New functionality includes testing
• New functionality has been documented
• New Roles/Permissions have a corresponding security dashboards plugin PR
• API changes companion pull request created
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.52%. Comparing base (2dbc508) to head (ec51813).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4725      +/-   ##
==========================================
- Coverage   65.54%   65.52%   -0.03%     
==========================================
  Files         319      319              
  Lines       22448    22448              
  Branches     3602     3602              
==========================================
- Hits        14714    14708       -6     
- Misses       5927     5929       +2     
- Partials     1807     1811       +4     

Files with missing lines	Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java	84.61% <100.00%> (+0.13%)	⬆️

... and 4 files with indirect coverage changes

[ahmedjami]

Hi there,

Was this fix well integrated into the v2.18.0?
I see that #4718 is still opened, so I want to confirm that the regression was fixed from 2.18.0.
Thanks in advance for you reply

[reta]

I see that #4718 is still opened, so I want to confirm that the regression was fixed from 2.18.0.

@ahmedjami waiting for confirmation from #4718 reporter the message is gone, this is why it is still open

[ahmedjami]

Thanks @reta for your reply.
Just to be sure regarding this PR, v2.18.0 was released including this fix?

[reta]

Just to be sure regarding this PR, v2.18.0 was released including this fix?

@ahmedjami correct

[ahmedjami]

One more question @reta please
Will this fix be backported to the previous version, especially 2.15 ?

[reta]

Will this fix be backported to the previous version, especially 2.15 ?

@ahmedjami No plans so far, we are not planning to have any patch releases for 2.15 line