Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.17 Backport] Adding index permissions for remote index in AD #4722

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

amitgalitz
Copy link
Member

Description

Backporting #4719 to 2.17

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.34%. Comparing base (d43de79) to head (d64b764).
Report is 3 commits behind head on 2.17.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             2.17    #4722      +/-   ##
==========================================
- Coverage   65.36%   65.34%   -0.03%     
==========================================
  Files         317      317              
  Lines       22158    22158              
  Branches     3581     3581              
==========================================
- Hits        14484    14479       -5     
- Misses       5878     5882       +4     
- Partials     1796     1797       +1     

see 3 files with indirect coverage changes

@cwperks cwperks merged commit cabff25 into opensearch-project:2.17 Sep 9, 2024
80 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants