Remove unnecessary stashContext usage in AbstractApiAction #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
DarshitChanpura,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4668 +/- ##
==========================================
- Coverage 65.29% 65.23% -0.06%
==========================================
Files 317 317
Lines 22312 22312
Branches 3589 3591 +2
==========================================
- Hits 14569 14556 -13
- Misses 5951 5957 +6
- Partials 1792 1799 +7
|
RyanL1997
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In anticipation of asking plugins to remove direct usages of threadContext.stashContext, I am looking at the Security repos usages. I found this usage inside AbstractApiAction that reads from the ThreadContext, stashes the context and then repopulates the context with original values. The stashContext appears to be unnecessary because it goes back to repopulating with original values.
I'm opening a PR to discuss the removal of this usage.
Maintenance
Issues Resolved
Related to opensearch-project/opensearch-plugins#238
Testing
CI Checks
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.