Fixes authtoken endpoint #4628
Merged
Fixes authtoken endpoint #4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
requested review from
cliu123,
cwperks,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
commented
Aug 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4628 +/- ##
==========================================
- Coverage 65.29% 65.28% -0.01%
==========================================
Files 317 317
Lines 22309 22309
Branches 3588 3588
==========================================
- Hits 14566 14564 -2
- Misses 5949 5950 +1
- Partials 1794 1795 +1
|
Signed-off-by: Darshit Chanpura <[email protected]>
willyborankin
approved these changes
Aug 9, 2024
shikharj05
approved these changes
Aug 9, 2024
derek-ho
reviewed
Aug 9, 2024
src/main/java/org/opensearch/security/dlic/rest/api/InternalUsersApiAction.java
Show resolved
Hide resolved
derek-ho
approved these changes
Aug 9, 2024
stephen-crawford
approved these changes
Aug 9, 2024
DarshitChanpura
merged commit 9e62096
into
opensearch-project:main
40 of 42 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 9e62096) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change ensures that authtoken endpoint works to vend authtoken for
internalusersAPI.The issue was root-caused to improperly handled generateAuthToken(). This PR modifies the associated method and adds missing tests for
/authtokenendpoint.Also fixes a small issue where
timeoutparameter is not working as expected for certificates API.Issues Resolved
/authtokenendpoint isn't working #4627Testing
Check List
- [ ] New functionality has been documented- [ ] New Roles/Permissions have a corresponding security dashboards plugin PR- [ ] API changes companion pull request createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.