[2.16] Revert change to use System Index Registry from core to determine if request matches system indices #4616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preparing this revert PR against 2.16 in case this change needs to be reverted.
During 2.16.0 release prep, integ tests with security were seen failing in Security Analytics Plugin and ISM:
Both of these plugins have SystemIndices registered through the extension point
SystemIndexRegistry.getSystemIndexDescriptors
, but do not have corresponding entries tracked in security plugins list of system indices. (See #4439 (comment) for registered system indices vs list tracked by security plugin)Each plugin needs to refactor to ensure that system index interaction is done in a privileged block, but I'm raising this PR in case a revert is needed.
There are 3 possible ways to move forward: